Changeset 177981 in webkit

Timestamp:

Jan 6, 2015, 11:39:05 AM (11 years ago)

Author:

mark.lam@apple.com

Message:

Fix Use details for op_create_lexical_environment and op_create_arguments.
<​https://webkit.org/b/140110>

Reviewed by Filip Pizlo.

The current "Use" details for op_create_lexical_environment and
op_create_arguments are wrong. op_create_argument uses nothing instead of the
1st operand (the output local). op_create_lexical_environment uses its 2nd
operand (the scope chain) instead of the 1st (the output local).
This patch fixes them to specify the proper uses.

• bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecode/BytecodeUseDef.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-01-06  Mark Lam  <mark.lam@apple.com>
+
+        Fix Use details for op_create_lexical_environment and op_create_arguments.
+        <https://webkit.org/b/140110>
+
+        Reviewed by Filip Pizlo.
+
+        The current "Use" details for op_create_lexical_environment and
+        op_create_arguments are wrong.  op_create_argument uses nothing instead of the
+        1st operand (the output local).  op_create_lexical_environment uses its 2nd
+        operand (the scope chain) instead of the 1st (the output local).
+        This patch fixes them to specify the proper uses.
+
+        * bytecode/BytecodeUseDef.h:
+        (JSC::computeUsesForBytecodeOffset):
+
 2015-01-06  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/JavaScriptCore/bytecode/BytecodeUseDef.h

@@ -41 +41 @@
     switch (opcodeID) {
     // No uses.
+    case op_create_arguments:
     case op_new_regexp:
     case op_new_array_buffer:
@@ -56 +57 @@
     case op_profile_control_flow:
         return;
-    case op_create_lexical_environment:
     case op_get_scope:
-    case op_create_arguments:
     case op_to_this:
     case op_pop_scope:
@@ -115 +114 @@
         return;
     }
+    case op_create_lexical_environment:
     case op_get_enumerable_length:
     case op_new_func_exp: