Changeset 181067 in webkit

Timestamp:

Mar 4, 2015, 9:14:53 PM (10 years ago)

Author:

ddkilzer@apple.com

Message:

Switch new soft-linking debug asserts to release asserts
<​http://webkit.org/b/142176>

Reviewed by Alex Christensen.

• platform/mac/SoftLinking.h:

(SOFT_LINK_CONSTANT_SOURCE): Switch to release assert.
(SOFT_LINK_FUNCTION_SOURCE): Ditto.

• platform/win/SoftLinking.h:

(SOFT_LINK_CONSTANT_SOURCE): Ditto.
(SOFT_LINK_FUNCTION_SOURCE): Ditto. Note that this method is
effectively only called once because the function pointer is
replaced after the first time it's called.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/SoftLinking.h (modified) (2 diffs)
• platform/win/SoftLinking.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-04  David Kilzer  <ddkilzer@apple.com>
+
+        Switch new soft-linking debug asserts to release asserts
+        <http://webkit.org/b/142176>
+
+        Reviewed by Alex Christensen.
+
+        * platform/mac/SoftLinking.h:
+        (SOFT_LINK_CONSTANT_SOURCE): Switch to release assert.
+        (SOFT_LINK_FUNCTION_SOURCE): Ditto.
+        * platform/win/SoftLinking.h:
+        (SOFT_LINK_CONSTANT_SOURCE): Ditto.
+        (SOFT_LINK_FUNCTION_SOURCE): Ditto.  Note that this method is
+        effectively only called once because the function pointer is
+        replaced after the first time it's called.
+
 2015-03-04  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/platform/mac/SoftLinking.h

@@ -338 +338 @@
         dispatch_once(&once, ^{ \
             void* constant = dlsym(framework##Library(), #variableName); \
-            ASSERT_WITH_MESSAGE(constant, "%s", dlerror()); \
+            RELEASE_ASSERT_WITH_MESSAGE(constant, "%s", dlerror()); \
             constant##framework##variableName = *static_cast<variableType*>(constant); \
         }); \
@@ -369 +369 @@
         dispatch_once(&once, ^{ \
             softLink##framework##functionName = (resultType (*) parameterDeclarations) dlsym(framework##Library(), #functionName); \
-            ASSERT_WITH_MESSAGE(softLink##framework##functionName, "%s", dlerror()); \
+            RELEASE_ASSERT_WITH_MESSAGE(softLink##framework##functionName, "%s", dlerror()); \
         }); \
         return softLink##framework##functionName parameterNames; \

trunk/Source/WebCore/platform/win/SoftLinking.h

@@ -214 +214 @@
     static void init##framework##variableName(void* context) { \
         variableType* ptr = reinterpret_cast<variableType*>(SOFT_LINK_GETPROCADDRESS(framework##Library(), #variableName)); \
-        ASSERT(ptr); \
+        RELEASE_ASSERT(ptr); \
         *static_cast<variableType*>(context) = *ptr; \
     } \
@@ -243 +243 @@
     { \
         softLink##framework##functionName = reinterpret_cast<resultType (__cdecl*)parameterDeclarations>(SOFT_LINK_GETPROCADDRESS(framework##Library(), #functionName)); \
-        ASSERT(softLink##framework##functionName); \
+        RELEASE_ASSERT(softLink##framework##functionName); \
         return softLink##framework##functionName parameterNames; \
     } \