Changeset 181662 in webkit

Timestamp:

Mar 17, 2015, 1:28:33 PM (10 years ago)

Author:

jer.noble@apple.com

Message:

REGRESSION (r181423): Crash @ generatedcontent.org at com.apple.WebCore: WebCore::MediaPlayer::maximumDurationToCacheMediaTime const + 4
​https://bugs.webkit.org/show_bug.cgi?id=142787

Reviewed by Eric Carlson.

Null check m_player before derefencing.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-17  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION (r181423): Crash @ generatedcontent.org at com.apple.WebCore: WebCore::MediaPlayer::maximumDurationToCacheMediaTime const + 4
+        https://bugs.webkit.org/show_bug.cgi?id=142787
+
+        Reviewed by Eric Carlson.
+
+        Null check m_player before derefencing.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::parseAttribute):
+
 2015-03-17  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -2475 +2475 @@
 void HTMLMediaElement::invalidateCachedTime() const
 {
-    if (!m_player->maximumDurationToCacheMediaTime())
+    if (!m_player || !m_player->maximumDurationToCacheMediaTime())
         return;