Changeset 182052 in webkit

Timestamp:

Mar 26, 2015, 11:36:48 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Optimized Fullscreen fails to cleanup because of no longer necessary release of m_playerController in exitFullscreen()
​https://bugs.webkit.org/show_bug.cgi?id=143120

Patch by Jeremy Jones <​jeremyj@apple.com> on 2015-03-26
Reviewed by Eric Carlson.

We used to release m_playerController in WebVideoFullscreenInterfaceAVKit::exitFullscreen() in order to make sure
media state was reset. This is no longer necessary as we now have a way the model can explicitly request resetting the
media state via resetMediaState(). m_playerController is already released in
WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releasing it prematurely can actually prevent the exit
fullscreen process from completing successfully.

• platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::exitFullscreen):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/WebVideoFullscreenInterfaceAVKit.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-26  Jeremy Jones  <jeremyj@apple.com>
+
+        Optimized Fullscreen fails to cleanup because of no longer necessary release of m_playerController in exitFullscreen()
+        https://bugs.webkit.org/show_bug.cgi?id=143120
+
+        Reviewed by Eric Carlson.
+
+        We used to release m_playerController in WebVideoFullscreenInterfaceAVKit::exitFullscreen() in order to make sure 
+        media state was reset. This is no longer necessary as we now have a way the model can explicitly request resetting the
+        media state via resetMediaState(). m_playerController is already released in 
+        WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releasing it prematurely can actually prevent the exit
+        fullscreen process from completing successfully.
+
+        * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+        (WebVideoFullscreenInterfaceAVKit::exitFullscreen):
+
 2015-03-26  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm

@@ -1025 +1025 @@
     }
 
-    m_playerController = nil;
-
     dispatch_async(dispatch_get_main_queue(), [strongThis, finalRect] {
         strongThis->exitFullscreenInternal(finalRect);