Changeset 182578 in webkit

Timestamp:

Apr 8, 2015, 6:37:52 PM (10 years ago)

Author:

Joseph Pecoraro

Message:

Fix uncaught exception seen in Inspector.

Reviewed by Timothy Hatcher.

• UserInterface/Views/TreeOutline.js:

(WebInspector.TreeOutline.prototype.removeChild):
Add a null check. Everywhere else null checks this member variable
which may not exist yet, this case was missing the check.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TreeOutline.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-04-08  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Fix uncaught exception seen in Inspector.
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/TreeOutline.js:
+        (WebInspector.TreeOutline.prototype.removeChild):
+        Add a null check. Everywhere else null checks this member variable
+        which may not exist yet, this case was missing the check.
+
 2015-04-08  Tobias Reiss  <tobi+webkit@basecode.de>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js

@@ -196 +196 @@
 
         if (!this.children.length) {
-            this._listItemNode.classList.remove("parent");
+            if (this._listItemNode)
+                this._listItemNode.classList.remove("parent");
             this.hasChildren = false;
         }