Changeset 182585 in webkit

Timestamp:

Apr 8, 2015, 8:44:44 PM (10 years ago)

Author:

Simon Fraser

Message:

Add a debug assertion that will fire if we try to paint layer contents on a background thread
​https://bugs.webkit.org/show_bug.cgi?id=143547

Reviewed by Alexey Proskuryakov.

New assertion to catch cases where other frameworks erroneously trigger painting
on a non-main (or non-Web) thread.

• platform/graphics/mac/WebLayer.mm:

(-[WebSimpleLayer display]):
(-[WebSimpleLayer drawInContext:]):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/mac/WebLayer.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-04-08  Simon Fraser  <simon.fraser@apple.com>
+
+        Add a debug assertion that will fire if we try to paint layer contents on a background thread
+        https://bugs.webkit.org/show_bug.cgi?id=143547
+
+        Reviewed by Alexey Proskuryakov.
+
+        New assertion to catch cases where other frameworks erroneously trigger painting
+        on a non-main (or non-Web) thread.
+
+        * platform/graphics/mac/WebLayer.mm:
+        (-[WebSimpleLayer display]):
+        (-[WebSimpleLayer drawInContext:]):
+
 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm

@@ -108 +108 @@
         WebThreadLock();
 #endif
+    ASSERT(isMainThread());
     [super display];
     PlatformCALayer* layer = PlatformCALayer::platformCALayer(self);
@@ -120 +121 @@
         WebThreadLock();
 #endif
+    ASSERT(isMainThread());
     PlatformCALayer* layer = PlatformCALayer::platformCALayer(self);
     if (layer && layer->owner()) {