Changeset 182592 in webkit


Ignore:
Timestamp:
Apr 8, 2015, 11:57:32 PM (10 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: Simplify Legacy Tips support
​https://bugs.webkit.org/show_bug.cgi?id=143551

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-04-08
Reviewed by Timothy Hatcher.

  • UserInterface/Models/ConsoleMessage.js:
  • UserInterface/Protocol/ConsoleObserver.js:

(WebInspector.ConsoleObserver.prototype.messageAdded):

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView):
(WebInspector.ConsoleMessageView.prototype._levelString):

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._filterMessageElements):

Location:
trunk/Source/WebInspectorUI
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r182583 r182592  
     12015-04-08  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Web Inspector: Simplify Legacy Tips support
     4        https://bugs.webkit.org/show_bug.cgi?id=143551
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        * UserInterface/Models/ConsoleMessage.js:
     9        * UserInterface/Protocol/ConsoleObserver.js:
     10        (WebInspector.ConsoleObserver.prototype.messageAdded):
     11        * UserInterface/Views/ConsoleMessageView.js:
     12        (WebInspector.ConsoleMessageView):
     13        (WebInspector.ConsoleMessageView.prototype._levelString):
     14        * UserInterface/Views/LogContentView.js:
     15        (WebInspector.LogContentView.prototype._filterMessageElements):
     16
    1172015-04-08  Joseph Pecoraro  <pecoraro@apple.com>
    218

  • trunk/Source/WebInspectorUI/UserInterface/Models/ConsoleMessage.js

    r182579 r182592  
    138138
    139139WebInspector.ConsoleMessage.MessageLevel = {
    140     Tip: "tip", // COMPATIBILITY (iOS 6)
    141140    Log: "log",
    142141    Warning: "warning",

  • trunk/Source/WebInspectorUI/UserInterface/Protocol/ConsoleObserver.js

    r182579 r182592  
    3030    messageAdded(message)
    3131    {
    32         // FIXME: We should convert "Tip" to "Log" here immediately.
     32        // COMPATIBILITY (iOS 6): Treat Tips like Logs.
     33        if (message.type === "tip")
     34            message.type = "log";
    3335
    3436        if (message.type === "assert" && !message.text)

  • trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js

    r182579 r182592  
    4747
    4848        switch (this._message.level) {
    49         case WebInspector.ConsoleMessage.MessageLevel.Tip: // COMPATIBILITY (iOS 6).
    5049        case WebInspector.ConsoleMessage.MessageLevel.Log:
    5150            this._element.classList.add("console-log-level");
    … …  
    648647    {
    649648        switch (this._message.level) {
    650         case WebInspector.ConsoleMessage.MessageLevel.Tip:
    651             return "Tip";
    652649        case WebInspector.ConsoleMessage.MessageLevel.Log:
    653650            return "Log";

  • trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js

    r182579 r182592  
    684684                    visible = showsErrors;
    685685                    break;
    686                 case WebInspector.ConsoleMessage.MessageLevel.Tip: // COMPATIBILITY (iOS 6): Treat Tips like Logs.
    687686                case WebInspector.ConsoleMessage.MessageLevel.Log:
    688687                case WebInspector.ConsoleMessage.MessageLevel.Debug:
Note: See TracChangeset for help on using the changeset viewer.