Changeset 182646 in webkit

Timestamp:

Apr 10, 2015, 5:50:42 PM (10 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: Fix Console Message Toggle

Unreviewed. Correct a post-review comment fix that went too far.

• UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype.set expandable):
The handler needed to be bound to the object.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ConsoleMessageView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-04-10  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Fix Console Message Toggle
+
+        Unreviewed. Correct a post-review comment fix that went too far.
+
+        * UserInterface/Views/ConsoleMessageView.js:
+        (WebInspector.ConsoleMessageView.prototype.set expandable):
+        The handler needed to be bound to the object.
+
 2015-04-10  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js

@@ -146 +146 @@
             return;
 
+        if (!this._boundClickHandler)
+            this._boundClickHandler = this.toggle.bind(this);
+
         var becameExpandable = this._element.classList.toggle("expandable", x);
 
         if (becameExpandable)
-            this._messageTextElement.addEventListener("click", this.toggle);
+            this._messageTextElement.addEventListener("click", this._boundClickHandler);
         else
-            this._messageTextElement.removeEventListener("click", this.toggle);
+            this._messageTextElement.removeEventListener("click", this._boundClickHandler);
     }