Changeset 182933 in webkit

Timestamp:

Apr 16, 2015, 6:00:21 PM (10 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: Should include "Log Value" context menu item in Preview and Collapsed ObjectTree
​https://bugs.webkit.org/show_bug.cgi?id=143845

Reviewed by Timothy Hatcher.

Give previews the same "Log Value" context menu so that if you just log
a bunch of objects to the console you can quickly turn that entire object
into a $n reference in the console to interact with.

• UserInterface/Views/ObjectPreviewView.js:

(WebInspector.ObjectPreviewView.prototype.setOriginatingObjectInfo):
(WebInspector.ObjectPreviewView.prototype._contextMenuHandler):
Provide API to refer to a RemoteObject and optional PropertyPath
that can be used to give the preview a "Log Value" context menu.

• UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._appendFormattedArguments):
Include the RemoteObject without a path for a preview context menu.

• UserInterface/Views/ObjectTreeView.js:

(WebInspector.ObjectTreeView):
Include the RemoteObject with a path if we knew it for a preview context menu.

• UserInterface/Views/ObjectTreeBaseTreeElement.js:

(WebInspector.ObjectTreeBaseTreeElement.prototype.createGetterElement):
The context menu can never be empty, since we always added at least one item above.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ConsoleMessageView.js (modified) (1 diff)
• UserInterface/Views/ObjectPreviewView.js (modified) (2 diffs)
• UserInterface/Views/ObjectTreeBaseTreeElement.js (modified) (1 diff)
• UserInterface/Views/ObjectTreeView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-04-16  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Should include "Log Value" context menu item in Preview and Collapsed ObjectTree
+        https://bugs.webkit.org/show_bug.cgi?id=143845
+
+        Reviewed by Timothy Hatcher.
+
+        Give previews the same "Log Value" context menu so that if you just log
+        a bunch of objects to the console you can quickly turn that entire object
+        into a $n reference in the console to interact with.
+
+        * UserInterface/Views/ObjectPreviewView.js:
+        (WebInspector.ObjectPreviewView.prototype.setOriginatingObjectInfo):
+        (WebInspector.ObjectPreviewView.prototype._contextMenuHandler):
+        Provide API to refer to a RemoteObject and optional PropertyPath
+        that can be used to give the preview a "Log Value" context menu.
+
+        * UserInterface/Views/ConsoleMessageView.js:
+        (WebInspector.ConsoleMessageView.prototype._appendFormattedArguments):
+        Include the RemoteObject without a path for a preview context menu.
+
+        * UserInterface/Views/ObjectTreeView.js:
+        (WebInspector.ObjectTreeView):
+        Include the RemoteObject with a path if we knew it for a preview context menu.
+
+        * UserInterface/Views/ObjectTreeBaseTreeElement.js:
+        (WebInspector.ObjectTreeBaseTreeElement.prototype.createGetterElement):
+        The context menu can never be empty, since we always added at least one item above.
+
+
 2015-04-16  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js

@@ -391 +391 @@
                 var preview = WebInspector.FormattedValue.createObjectPreviewOrFormattedValueForRemoteObject(parameter, WebInspector.ObjectPreviewView.Mode.Brief);
                 var isPreviewView = preview instanceof WebInspector.ObjectPreviewView;
+
+                if (isPreviewView)
+                    preview.setOriginatingObjectInfo(parameter, null);
+
                 var previewElement = isPreviewView ? preview.element : preview;
                 previewContainer.appendChild(previewElement);

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js

@@ -91 +91 @@
     }
 
+    setOriginatingObjectInfo(remoteObject, propertyPath)
+    {
+        console.assert(!this._remoteObject);
+        console.assert(remoteObject instanceof WebInspector.RemoteObject);
+        console.assert(!propertyPath || propertyPath instanceof WebInspector.PropertyPath);
+
+        this._remoteObject = remoteObject;
+        this._propertyPath = propertyPath || null;
+
+        this.element.addEventListener("contextmenu", this._contextMenuHandler.bind(this));
+    }
+
     // Private
 
@@ -224 +236 @@
         return true;
     }
+
+    _contextMenuHandler(event)
+    {
+        var contextMenu = new WebInspector.ContextMenu(event);
+
+        contextMenu.appendItem(WebInspector.UIString("Log Value"), function() {
+            var remoteObject = this._remoteObject;
+            var isImpossible = !this._propertyPath || this._propertyPath.isFullPathImpossible();
+            var text = isImpossible ? WebInspector.UIString("Selected Value") : this._propertyPath.displayPath(WebInspector.PropertyPath.Type.Value);
+
+            if (!isImpossible)
+                WebInspector.quickConsole.prompt.pushHistoryItem(text);
+
+            WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, this._remoteObject);
+        }.bind(this));
+
+        contextMenu.show();        
+    }
 };
 

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js

@@ -205 +205 @@
         this._appendMenusItemsForObject(contextMenu, resolvedValue);
 
-        if (!contextMenu.isEmpty())
-            contextMenu.show();
+        contextMenu.show();
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js

@@ -33 +33 @@
         console.assert(!propertyPath || propertyPath instanceof WebInspector.PropertyPath);
 
+        var providedPropertyPath = propertyPath instanceof WebInspector.PropertyPath;
+
         this._object = object;
         this._mode = mode || WebInspector.ObjectTreeView.defaultModeForObject(object);
@@ -53 +55 @@
         if (this._object.preview) {
             this._previewView = new WebInspector.ObjectPreviewView(this._object.preview);
+            this._previewView.setOriginatingObjectInfo(this._object, providedPropertyPath ? propertyPath : null);
             this._previewView.element.addEventListener("click", this._handlePreviewOrTitleElementClick.bind(this));
             this._element.appendChild(this._previewView.element);