Changeset 182990 in webkit


Ignore:
Timestamp:
Apr 18, 2015, 9:20:46 PM (10 years ago)
Author:
Nikita Vasilyev
Message:

Web Inspector: Pass multiple arguments to classList.add and classList.remove
​https://bugs.webkit.org/show_bug.cgi?id=143914

classList.add and classList.remove can accept multiple arguments, use that.

Reviewed by Timothy Hatcher.

  • UserInterface/Base/Main.js:

(WebInspector.updateDockedState):

  • UserInterface/Views/DOMTreeDataGrid.js:

(WebInspector.DOMTreeDataGrid):

  • UserInterface/Views/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline):

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGridNode.prototype.set hasChildren):

  • UserInterface/Views/DatabaseContentView.js:

(WebInspector.DatabaseContentView):

  • UserInterface/Views/DetailsSection.js:

(WebInspector.DetailsSection):

  • UserInterface/Views/DetailsSectionPropertiesRow.js:

(WebInspector.DetailsSectionPropertiesRow):

  • UserInterface/Views/GeneralTreeElement.js:

(WebInspector.GeneralTreeElement.prototype.set classNames):

  • UserInterface/Views/NavigationItem.js:

(WebInspector.NavigationItem):

  • UserInterface/Views/ResourceContentView.js:

(WebInspector.ResourceContentView):

  • UserInterface/Views/ResourceTimelineDataGridNode.js:

(WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):

  • UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar):

  • UserInterface/Views/SidebarPanel.js:

(WebInspector.SidebarPanel):

  • UserInterface/Views/SourceCodeTextEditor.js:
  • UserInterface/Views/TextEditor.js:

(WebInspector.TextEditor):

  • UserInterface/Views/TimelineRuler.js:
Location:
trunk/Source/WebInspectorUI
Files:
17 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r182989 r182990  
     12015-04-18  Nikita Vasilyev  <nvasilyev@apple.com>
     2
     3        Web Inspector: Pass multiple arguments to classList.add and classList.remove
     4        https://bugs.webkit.org/show_bug.cgi?id=143914
     5
     6        classList.add and classList.remove can accept multiple arguments, use that.
     7
     8        Reviewed by Timothy Hatcher.
     9
     10        * UserInterface/Base/Main.js:
     11        (WebInspector.updateDockedState):
     12        * UserInterface/Views/DOMTreeDataGrid.js:
     13        (WebInspector.DOMTreeDataGrid):
     14        * UserInterface/Views/DOMTreeOutline.js:
     15        (WebInspector.DOMTreeOutline):
     16        * UserInterface/Views/DataGrid.js:
     17        (WebInspector.DataGridNode.prototype.set hasChildren):
     18        * UserInterface/Views/DatabaseContentView.js:
     19        (WebInspector.DatabaseContentView):
     20        * UserInterface/Views/DetailsSection.js:
     21        (WebInspector.DetailsSection):
     22        * UserInterface/Views/DetailsSectionPropertiesRow.js:
     23        (WebInspector.DetailsSectionPropertiesRow):
     24        * UserInterface/Views/GeneralTreeElement.js:
     25        (WebInspector.GeneralTreeElement.prototype.set classNames):
     26        * UserInterface/Views/NavigationItem.js:
     27        (WebInspector.NavigationItem):
     28        * UserInterface/Views/ResourceContentView.js:
     29        (WebInspector.ResourceContentView):
     30        * UserInterface/Views/ResourceTimelineDataGridNode.js:
     31        (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
     32        * UserInterface/Views/Sidebar.js:
     33        (WebInspector.Sidebar):
     34        * UserInterface/Views/SidebarPanel.js:
     35        (WebInspector.SidebarPanel):
     36        * UserInterface/Views/SourceCodeTextEditor.js:
     37        * UserInterface/Views/TextEditor.js:
     38        (WebInspector.TextEditor):
     39        * UserInterface/Views/TimelineRuler.js:
     40
    1412015-04-18  Nikita Vasilyev  <nvasilyev@apple.com>
    242

  • trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

    r182777 r182990  
    458458
    459459    if (side === "bottom") {
    460         document.body.classList.add("docked");
    461         document.body.classList.add("bottom");
    462 
    463         document.body.classList.remove("window-inactive");
    464         document.body.classList.remove("right");
     460        document.body.classList.add("docked", "bottom");
     461        document.body.classList.remove("window-inactive", "right");
    465462
    466463        this.toolbar.displayMode = this._toolbarDockedBottomDisplayModeSetting.value;
    467464        this.toolbar.sizeMode = this._toolbarDockedBottomSizeModeSetting.value;
    468465    } else if (side === "right") {
    469         document.body.classList.add("docked");
    470         document.body.classList.add("right");
    471 
    472         document.body.classList.remove("window-inactive");
    473         document.body.classList.remove("bottom");
     466        document.body.classList.add("docked", "right");
     467        document.body.classList.remove("window-inactive", "bottom");
    474468
    475469        this.toolbar.displayMode = this._toolbarDockedRightDisplayModeSetting.value;
    476470        this.toolbar.sizeMode = this._toolbarDockedRightSizeModeSetting.value;
    477471    } else {
    478         document.body.classList.remove("docked");
    479         document.body.classList.remove("right");
    480         document.body.classList.remove("bottom");
     472        document.body.classList.remove("docked", "right", "bottom");
    481473
    482474        this.toolbar.displayMode = this._toolbarUndockedDisplayModeSetting.value;

  • trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js

    r172399 r182990  
    3131    this._previousHoveredElement = null;
    3232
    33     this.element.classList.add("dom-tree-data-grid");
    34     this.element.classList.add("inline");
     33    this.element.classList.add("inline", "dom-tree-data-grid");
    3534
    3635    this.element.addEventListener("mousemove", this._onmousemove.bind(this), false);

  • trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js

    r182909 r182990  
    4646        element.addEventListener("dragend", this._ondragend.bind(this), false);
    4747
    48         element.classList.add("dom-tree-outline");
    49         element.classList.add(WebInspector.SyntaxHighlightedStyleClassName);
     48        element.classList.add("dom-tree-outline", WebInspector.SyntaxHighlightedStyleClassName);
    5049
    5150        this._includeRootDOMNode = !omitRootDOMNode;

  • trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js

    r182092 r182990  
    14551455        else
    14561456        {
    1457             this._element.classList.remove("parent");
    1458             this._element.classList.remove("expanded");
     1457            this._element.classList.remove("parent", "expanded");
    14591458        }
    14601459    },

  • trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js

    r178155 r182990  
    3030    this.database = representedObject;
    3131
    32     this.element.classList.add("storage-view");
    33     this.element.classList.add("query");
    34     this.element.classList.add("monospace");
     32    this.element.classList.add("storage-view", "query", "monospace");
    3533
    3634    this._promptElement = document.createElement("div");

  • trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.js

    r182040 r182990  
    3333
    3434        this._element = document.createElement("div");
    35         this._element.className = WebInspector.DetailsSection.StyleClassName;
    36         this._element.classList.add(identifier);
     35        this._element.classList.add(identifier, "details-section");
    3736
    3837        this._headerElement = document.createElement("div");
    … …  
    162161};
    163162
    164 WebInspector.DetailsSection.StyleClassName = "details-section";
    165163WebInspector.DetailsSection.HeaderElementStyleClassName = "header";
    166164WebInspector.DetailsSection.TitleElementStyleClassName = "title";

  • trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSectionPropertiesRow.js

    r182040 r182990  
    3030        super(emptyMessage);
    3131
    32         this.element.classList.add("properties");
    33         this.element.classList.add(WebInspector.SyntaxHighlightedStyleClassName);
     32        this.element.classList.add("properties", WebInspector.SyntaxHighlightedStyleClassName);
    3433
    3534        this.propertiesSection = propertiesSection;

  • trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js

    r182909 r182990  
    7878    {
    7979        if (this._listItemNode && this._classNames) {
    80             for (var i = 0; i < this._classNames.length; ++i)
    81                 this._listItemNode.classList.remove(this._classNames[i]);
     80            this._listItemNode.classList.remove(...this._classNames);
    8281        }
    8382
    … …  
    8887
    8988        if (this._listItemNode) {
    90             for (var i = 0; i < this._classNames.length; ++i)
    91                 this._listItemNode.classList.add(this._classNames[i]);
     89            this._listItemNode.classList.add(...this._classNames);
    9290        }
    9391    }
    … …  
    223221
    224222        if (this._classNames) {
    225             for (var i = 0; i < this._classNames.length; ++i)
    226                 this._listItemNode.classList.add(this._classNames[i]);
     223            this._listItemNode.classList.add(...this._classNames);
    227224        }
    228225

  • trunk/Source/WebInspectorUI/UserInterface/Views/NavigationItem.js

    r181769 r182990  
    3838        this._element.setAttribute("aria-label", label);
    3939
    40     var classNames = this._classNames;
    41     for (var i = 0; i < classNames.length; ++i)
    42         this._element.classList.add(classNames[i]);
    43 
     40    this._element.classList.add(...this._classNames);
    4441    this._element.navigationItem = this;
    4542};

  • trunk/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js

    r178970 r182990  
    3333    this._resource = resource;
    3434
    35     this.element.classList.add(WebInspector.ResourceContentView.StyleClassName);
    36     this.element.classList.add(styleClassName);
     35    this.element.classList.add(styleClassName, "resource");
    3736
    3837    // Append a spinner while waiting for contentAvailable. The subclasses are responsible for removing
    … …  
    5453    }
    5554};
    56 
    57 WebInspector.ResourceContentView.StyleClassName = "resource";
    5855
    5956WebInspector.ResourceContentView.prototype = {

  • trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js

    r181769 r182990  
    108108        switch (columnIdentifier) {
    109109        case "name":
    110             cell.classList.add(WebInspector.ResourceTreeElement.ResourceIconStyleClassName);
    111             cell.classList.add(resource.type);
     110            cell.classList.add(resource.type, WebInspector.ResourceTreeElement.ResourceIconStyleClassName);
    112111
    113112            var fragment = document.createDocumentFragment();

  • trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js

    r182113 r182990  
    3434
    3535        this._element = element || document.createElement("div");
    36         this._element.classList.add("sidebar");
    37         this._element.classList.add(WebInspector.Sidebar.CollapsedStyleClassName);
    38         this._element.classList.add(this._side);
     36        this._element.classList.add("sidebar", this._side, WebInspector.Sidebar.CollapsedStyleClassName);
    3937
    4038        this._element.setAttribute("role", role || "group");

  • trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js

    r182041 r182990  
    3737
    3838        this._element = element || document.createElement("div");
    39         this._element.classList.add("panel");
    40         this._element.classList.add(identifier);
     39        this._element.classList.add("panel", identifier);
    4140
    4241        this._element.setAttribute("role", role || "group");

  • trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js

    r182142 r182990  
    841841
    842842        var widgetElement = widget.widgetElement;
    843         widgetElement.classList.add("issue-widget");
    844         widgetElement.classList.add("inline");
     843        widgetElement.classList.add("issue-widget", "inline");
    845844        widgetElement.addEventListener("click", this._handleWidgetClick.bind(this, widget, lineNumber));
    846845

  • trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js

    r182142 r182990  
    3131
    3232        this._element = element || document.createElement("div");
    33         this._element.classList.add("text-editor");
    34         this._element.classList.add(WebInspector.SyntaxHighlightedStyleClassName);
     33        this._element.classList.add("text-editor", WebInspector.SyntaxHighlightedStyleClassName);
    3534
    3635        this._codeMirror = CodeMirror(this.element, {

  • trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js

    r182142 r182990  
    292292
    293293        var markerElement = document.createElement("div");
    294         markerElement.classList.add(WebInspector.TimelineRuler.BaseMarkerElementStyleClassName);
    295         markerElement.classList.add(marker.type);
     294        markerElement.classList.add(marker.type, WebInspector.TimelineRuler.BaseMarkerElementStyleClassName);
    296295
    297296        this._markerElementMap.set(marker, markerElement);
Note: See TracChangeset for help on using the changeset viewer.