Changeset 183376 in webkit

Timestamp:

Apr 26, 2015, 6:25:50 PM (10 years ago)

Author:

timothy@apple.com

Message:

Web Inspector: Allow Timeline tab to show resource when a go-to arrow is clicked in a recording
​https://bugs.webkit.org/show_bug.cgi?id=144240

Only support showing a resource or script if we have that represented object in the Timeline sidebar.

Reviewed by Darin Adler.

• UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView.prototype.canShowRepresentedObject):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TimelineTabContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-04-26  Timothy Hatcher  <timothy@apple.com>
+
+        Web Inspector: Allow Timeline tab to show resource when a go-to arrow is clicked in a recording
+        https://bugs.webkit.org/show_bug.cgi?id=144240
+
+        Only support showing a resource or script if we have that represented object in the Timeline sidebar.
+
+        Reviewed by Darin Adler.
+
+        * UserInterface/Views/TimelineTabContentView.js:
+        (WebInspector.TimelineTabContentView.prototype.canShowRepresentedObject):
+
 2015-04-26  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js

@@ -48 +48 @@
     canShowRepresentedObject: function(representedObject)
     {
-        return representedObject instanceof WebInspector.TimelineRecording;
+        if (representedObject instanceof WebInspector.TimelineRecording)
+            return true;
+
+        // Only support showing a resource or script if we have that represented object in the sidebar.
+        if (representedObject instanceof WebInspector.Resource || representedObject instanceof WebInspector.Script)
+            return !!this.navigationSidebarPanel.treeElementForRepresentedObject(representedObject);
+
+        return false;
     },