Changeset 184601 in webkit

Timestamp:

May 19, 2015, 4:59:27 PM (10 years ago)

Author:

roger_fong@apple.com

Message:

Upper half of volume control should be filled, not hollow.
​https://bugs.webkit.org/show_bug.cgi?id=145187.
<rdar://problem/21021970>

Reviewed by Dean Jackson.

• Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.drawVolumeBackground):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediacontrols/mediaControlsApple.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-05-19  Roger Fong  <roger_fong@apple.com>
+
+        Upper half of volume control should be filled, not hollow.
+        https://bugs.webkit.org/show_bug.cgi?id=145187.
+        <rdar://problem/21021970>
+
+        Reviewed by Dean Jackson.
+
+        * Modules/mediacontrols/mediaControlsApple.js:
+        (Controller.prototype.drawVolumeBackground):
+
 2015-05-19  Michael Saboff  <msaboff@apple.com>
 

trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js

@@ -1269 +1269 @@
         ctx.restore();
         
-        // Draw volume track border.
+        // Draw portion of volume above slider thumb.
         ctx.save();
         ctx.beginPath();
         this.addRoundedRect(ctx, scrubberPosition, 3, width - scrubberPosition, timelineHeight, timelineHeight / 2.0);
-        this.addRoundedRect(ctx, scrubberPosition + 1, 4, width - borderSize - scrubberPosition - 1, trackHeight, trackHeight / 2.0);
         ctx.closePath();
-        ctx.clip("evenodd");
+        ctx.clip();
         ctx.fillStyle = "rgb(30, 30, 30)";
         ctx.fillRect(0, 0, width, height);