Changeset 184823 in webkit

Timestamp:

May 23, 2015, 8:03:43 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Improve native parameter lists a bit
​https://bugs.webkit.org/show_bug.cgi?id=145338

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-23
Reviewed by Timothy Hatcher.

• UserInterface/Models/NativeFunctionParameters.js:
• UserInterface/Views/ObjectTreePropertyTreeElement.js:

(WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/NativeFunctionParameters.js (modified) (9 diffs)
• UserInterface/Views/ObjectTreePropertyTreeElement.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-05-23  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Improve native parameter lists a bit
+        https://bugs.webkit.org/show_bug.cgi?id=145338
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Models/NativeFunctionParameters.js:
+        * UserInterface/Views/ObjectTreePropertyTreeElement.js:
+        (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
+
 2015-05-23  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js

@@ -31 +31 @@
         assign: "target, ...sources",
         create: "prototype, [propertiesObject]",
+        defineProperties: "object, properties",
         defineProperty: "object, propertyName, descriptor",
-        defineProperties: "object, properties",
         freeze: "object",
         getOwnPropertyDescriptor: "object, propertyName",
@@ -38 +38 @@
         getOwnPropertySymbols: "object",
         getPrototypeOf: "object",
+        is: "value1, value2",
         isExtensible: "object",
         isFrozen: "object",
@@ -44 +45 @@
         preventExtensions: "object",
         seal: "object",
+        setPrototypeOf: "object, prototype",
         __proto__: null,
     },
@@ -76 +78 @@
         asin: "x",
         asinh: "x",
+        atan2: "y, x",
         atan: "x",
-        atan2: "y, x",
         atanh: "x",
         cbrt: "x",
         ceil: "x",
+        clz32: "x",
         cos: "x",
         cosh: "x",
@@ -97 +100 @@
         pow: "x, y",
         round: "x",
+        sign: "x",
         sin: "x",
         sinh: "x",
@@ -127 +131 @@
 
     String: {
-        fromCharCode: "code, [...codes]",
+        fromCharCode: "...codeUnits",
+        fromCodePoint: "...codePoints",
+        raw: "template, ...substitutions",
         __proto__: null,
     },
@@ -301 +307 @@
         charAt: "index",
         charCodeAt: "index",
+        codePoints: "index",
         concat: "string, ...",
         includes: "searchValue, [startIndex=0]",
@@ -307 +314 @@
         localeCompare: "string",
         match: "regex",
+        repeat: "count",
         replace: "regex|string, replaceString|replaceHandler, [flags]",
         search: "regex",
@@ -734 +742 @@
 
     DocumentFragment: {
+        getElementById: "id",
         querySelector: "selectors",
         querySelectorAll: "selectors",

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js

@@ -258 +258 @@
             }
 
+            var parentDescription = this._propertyPath.object.description;
+
             // Native function property on a native function is likely a "Foo.method".
-            if (isFunctionStringNativeCode(this._propertyPath.object.description)) {
-                var match = this._propertyPath.object.description.match(/^function\s+([^)]+?)\(/);
+            if (isFunctionStringNativeCode(parentDescription)) {
+                var match = parentDescription.match(/^function\s+([^)]+?)\(/);
                 if (match) {
                     var name = match[1];
@@ -270 +272 @@
             }
 
-            // Native DOM constructor.
-            if (this._propertyPath.object.description.endsWith("Constructor")) {
-                var name = this._propertyPath.object.description;
+            // Native DOM constructor or on native objects that are not functions.
+            if (parentDescription.endsWith("Constructor") || parentDescription === "Math" || parentDescription === "JSON") {
+                var name = parentDescription;
                 if (WebInspector.NativeConstructorFunctionParameters[name]) {
                     var params = WebInspector.NativeConstructorFunctionParameters[name][this._property.name];