Changeset 185709 in webkit

Timestamp:

Jun 18, 2015, 10:58:33 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: New Rule button doesn't reveal the newly added rule if not visible upon creation
​https://bugs.webkit.org/show_bug.cgi?id=117600

Patch by Devin Rousso <Devin Rousso> on 2015-06-18
Reviewed by Timothy Hatcher.

• UserInterface/Views/RulesStyleDetailsPanel.js: Made previousFocusedSection into a member variable of the RulesStyleDetailsPanel. This way, when the nodeStyles is refreshed (when a new rule is added), the previousFocusedSection will be scrolled into view.

(WebInspector.RulesStyleDetailsPanel):
(WebInspector.RulesStyleDetailsPanel.prototype.refresh.appendStyleSection):
(WebInspector.RulesStyleDetailsPanel.prototype.nodeStylesRefreshed):
(WebInspector.RulesStyleDetailsPanel.prototype.refresh): Deleted.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/RulesStyleDetailsPanel.js (modified) (6 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-06-18  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: New Rule button doesn't reveal the newly added rule if not visible upon creation
+        https://bugs.webkit.org/show_bug.cgi?id=117600
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/RulesStyleDetailsPanel.js: Made previousFocusedSection into a member variable of the RulesStyleDetailsPanel.  This way, when the nodeStyles is refreshed (when a new rule is added), the previousFocusedSection will be scrolled into view.
+        (WebInspector.RulesStyleDetailsPanel):
+        (WebInspector.RulesStyleDetailsPanel.prototype.refresh.appendStyleSection):
+        (WebInspector.RulesStyleDetailsPanel.prototype.nodeStylesRefreshed):
+        (WebInspector.RulesStyleDetailsPanel.prototype.refresh): Deleted.
+
 2015-06-18  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js

@@ -31 +31 @@
 
         this._sections = [];
+        this._previousFocusedSection = null;
         this._propertyToSelectAndHighlight = null;
     }
@@ -48 +49 @@
         var previousMediaList = [];
         var previousSection = null;
-        var previousFocusedSection = null;
 
         function mediaListsEqual(a, b)
@@ -117 +117 @@
         {
             var section = style.__rulesSection;
-            if (section && section.focused && !previousFocusedSection)
-                previousFocusedSection = section;
+            if (section && section.focused && !this._previousFocusedSection)
+                this._previousFocusedSection = section;
 
             if (!section) {
@@ -127 +127 @@
 
             if (this._focusNextNewInspectorRule && style.ownerRule && style.ownerRule.type === WebInspector.CSSRule.Type.Inspector) {
-                previousFocusedSection = section;
+                this._previousFocusedSection = section;
                 delete this._focusNextNewInspectorRule;
             }
@@ -238 +238 @@
         for (var i = 0; i < this._sections.length; ++i)
             this._sections[i].updateLayout();
-
-        if (previousFocusedSection)
-            previousFocusedSection.focus();
     }
 
@@ -305 +302 @@
             this._propertyToSelectAndHighlight = null;
         }
+
+        if (this._previousFocusedSection && this._visible) {
+            this._previousFocusedSection.focus();
+            this._previousFocusedSection = null;
+        }
     }