Changeset 185771 in webkit

Timestamp:

Jun 19, 2015, 3:24:55 PM (10 years ago)

Author:

dino@apple.com

Message:

Played <audio> looks invisible against the gray background
​https://bugs.webkit.org/show_bug.cgi?id=146164
<rdar://problem/21014284>

Reviewed by Brent Fulgham.

The plus-darker blend mode was not allowing any white to
show through in the rendering. We don't need this for
audio controls, where we draw on an opaque grey background.

• Modules/mediacontrols/mediaControlsiOS.css:

(audio::-webkit-media-controls-panel): Darken the color of the controls a
little to make white stand out more.
(audio::-webkit-media-controls-timeline): Remove the plus-darker blending.
(video::-webkit-media-controls-timeline): Apply blending only to video.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediacontrols/mediaControlsiOS.css (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-06-19  Dean Jackson  <dino@apple.com>
+
+        Played <audio> looks invisible against the gray background
+        https://bugs.webkit.org/show_bug.cgi?id=146164
+        <rdar://problem/21014284>
+
+        Reviewed by Brent Fulgham.
+
+        The plus-darker blend mode was not allowing any white to
+        show through in the rendering. We don't need this for
+        audio controls, where we draw on an opaque grey background.
+
+        * Modules/mediacontrols/mediaControlsiOS.css:
+        (audio::-webkit-media-controls-panel): Darken the color of the controls a
+        little to make white stand out more.
+        (audio::-webkit-media-controls-timeline): Remove the plus-darker blending.
+        (video::-webkit-media-controls-timeline): Apply blending only to video.
+
 2015-06-19  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css

@@ -168 +168 @@
 audio::-webkit-media-controls-panel {
     height: 39px;
-    background-color: rgba(228, 228, 228, 1);
+    background-color: rgba(212, 212, 212, 1);
 }
 
@@ -361 +361 @@
     box-sizing: content-box !important;
     -webkit-transform: translate3d(0, 0, 0);
+}
+
+video::-webkit-media-controls-timeline {
     mix-blend-mode: plus-darker;
 }