Changeset 185917 in webkit

Timestamp:

Jun 24, 2015, 10:57:49 AM (10 years ago)

Author:

timothy_horton@apple.com

Message:

REGRESSION (r185804): Crash selecting time in the form on ​https://backup.brighthorizons.com/BackupCareRequest.aspx
<rdar://problem/21525376>

Reviewed by Sam Weinig.

• page/TextIndicator.cpp:

(WebCore::TextIndicator::createWithRange):
Null check.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/TextIndicator.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-06-24  Tim Horton  <timothy_horton@apple.com>
+
+        REGRESSION (r185804): Crash selecting time in the form on https://backup.brighthorizons.com/BackupCareRequest.aspx
+        <rdar://problem/21525376>
+
+        Reviewed by Sam Weinig.
+
+        * page/TextIndicator.cpp:
+        (WebCore::TextIndicator::createWithRange):
+        Null check.
+
 2015-06-24  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/page/TextIndicator.cpp

@@ -106 +106 @@
     frame->selection().setSelection(oldSelection);
 
-    indicator->setWantsMargin(!areRangesEqual(&range, oldSelection.toNormalizedRange().get()));
+    if (indicator)
+        indicator->setWantsMargin(!areRangesEqual(&range, oldSelection.toNormalizedRange().get()));
     
     return indicator.release();