Changeset 186561 in webkit

Timestamp:

Jul 8, 2015, 6:14:03 PM (10 years ago)

Author:

timothy@apple.com

Message:

Web Inspector: Only record a timeline when the Timelines tab is showing
​https://bugs.webkit.org/show_bug.cgi?id=146759

Reviewed by Joseph Pecoraro.

• UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.get autoCaptureOnPageLoad):
(WebInspector.TimelineManager.prototype.set autoCaptureOnPageLoad):
(WebInspector.TimelineManager.prototype._startAutoCapturing):

• UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView.prototype.shown):
(WebInspector.TimelineTabContentView.prototype.hidden):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/TimelineManager.js (modified) (2 diffs)
• UserInterface/Views/TimelineTabContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-07-08  Timothy Hatcher  <timothy@apple.com>
+
+        Web Inspector: Only record a timeline when the Timelines tab is showing
+        https://bugs.webkit.org/show_bug.cgi?id=146759
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Controllers/TimelineManager.js:
+        (WebInspector.TimelineManager.prototype.get autoCaptureOnPageLoad):
+        (WebInspector.TimelineManager.prototype.set autoCaptureOnPageLoad):
+        (WebInspector.TimelineManager.prototype._startAutoCapturing):
+        * UserInterface/Views/TimelineTabContentView.js:
+        (WebInspector.TimelineTabContentView.prototype.shown):
+        (WebInspector.TimelineTabContentView.prototype.hidden):
+
 2015-07-08  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js

@@ -75 +75 @@
     }
 
+    get autoCaptureOnPageLoad()
+    {
+        return this._autoCaptureOnPageLoad;
+    }
+
+    set autoCaptureOnPageLoad(autoCapture)
+    {
+        this._autoCaptureOnPageLoad = autoCapture;
+    }
+
     isCapturing()
     {
@@ -505 +515 @@
     _startAutoCapturing(event)
     {
+        if (!this._autoCaptureOnPageLoad)
+            return false;
+
         if (!event.target.isMainFrame() || (this._isCapturing && !this._autoCapturingMainResource))
             return false;

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js

@@ -43 +43 @@
     },
 
+    shown: function()
+    {
+        WebInspector.ContentBrowserTabContentView.prototype.shown.call(this);
+
+        WebInspector.timelineManager.autoCaptureOnPageLoad = true;
+    },
+
+    hidden: function()
+    {
+        WebInspector.ContentBrowserTabContentView.prototype.hidden.call(this);
+
+        WebInspector.timelineManager.autoCaptureOnPageLoad = false;
+    },
+
     canShowRepresentedObject: function(representedObject)
     {