Changeset 188330 in webkit

Timestamp:

Aug 11, 2015, 11:05:08 PM (10 years ago)

Author:

Matt Baker

Message:

Web Inspector: TimelineView data not cleared when recording is reset
​https://bugs.webkit.org/show_bug.cgi?id=147916

Reviewed by Timothy Hatcher.

Each derived timeline view maintains a separate array of timeline records. These weren't
cleared on reset, so switching to a timeline view after clearing the recording caused
the view to populate its tree outline.

• UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView.set columns):
(WebInspector.LayoutTimelineView):

• UserInterface/Views/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView.set columns):
(WebInspector.NetworkTimelineView):

• UserInterface/Views/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype.reset):
(WebInspector.OverviewTimelineView.prototype._processPendingRepresentedObjects):

• UserInterface/Views/RenderingFrameTimelineView.js:

(WebInspector.RenderingFrameTimelineView.prototype.reset):

• UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype.reset):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/LayoutTimelineView.js (modified) (1 diff)
• UserInterface/Views/NetworkTimelineView.js (modified) (1 diff)
• UserInterface/Views/OverviewTimelineView.js (modified) (2 diffs)
• UserInterface/Views/RenderingFrameTimelineView.js (modified) (1 diff)
• UserInterface/Views/ScriptTimelineView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-08-11  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: TimelineView data not cleared when recording is reset
+        https://bugs.webkit.org/show_bug.cgi?id=147916
+
+        Reviewed by Timothy Hatcher.
+
+        Each derived timeline view maintains a separate array of timeline records. These weren't
+        cleared on reset, so switching to a timeline view after clearing the recording caused
+        the view to populate its tree outline.
+
+        * UserInterface/Views/LayoutTimelineView.js:
+        (WebInspector.LayoutTimelineView.set columns):
+        (WebInspector.LayoutTimelineView):
+        * UserInterface/Views/NetworkTimelineView.js:
+        (WebInspector.NetworkTimelineView.set columns):
+        (WebInspector.NetworkTimelineView):
+        * UserInterface/Views/OverviewTimelineView.js:
+        (WebInspector.OverviewTimelineView.prototype.reset):
+        (WebInspector.OverviewTimelineView.prototype._processPendingRepresentedObjects):
+        * UserInterface/Views/RenderingFrameTimelineView.js:
+        (WebInspector.RenderingFrameTimelineView.prototype.reset):
+        * UserInterface/Views/ScriptTimelineView.js:
+        (WebInspector.ScriptTimelineView.prototype.reset):
+
 2015-08-11  Matt Baker  <mattbaker@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js

@@ -155 +155 @@
 
         this._dataGrid.reset();
+
+        this._pendingRecords = [];
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js

@@ -149 +149 @@
 
         this._dataGrid.reset();
+
+        this._pendingRecords = [];
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js

@@ -143 +143 @@
     }
 
+    reset()
+    {
+        super.reset();
+
+        this._pendingRepresentedObjects = [];
+    }
+
     // Protected
 
@@ -307 +314 @@
     _processPendingRepresentedObjects()
     {
-        if (!this._pendingRepresentedObjects || !this._pendingRepresentedObjects.length)
+        if (!this._pendingRepresentedObjects.length)
             return;
 

trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js

@@ -190 +190 @@
 
         this._dataGrid.reset();
+
+        this._pendingRecords = [];
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTimelineView.js

@@ -163 +163 @@
 
         this._dataGrid.reset();
+
+        this._pendingRecords = [];
     }