Changeset 189986 in webkit

Timestamp:

Sep 18, 2015, 2:37:17 PM (10 years ago)

Author:

Beth Dakin

Message:

Snapshots broken on iOS
​https://bugs.webkit.org/show_bug.cgi?id=149354

Reviewed by Tim Horton.

We need to send the IOSurface to ViewSnapshot::create() for this to work.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _takeViewSnapshot]):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKWebView.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-09-18  Beth Dakin  <bdakin@apple.com>
+
+        Snapshots broken on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=149354
+
+        Reviewed by Tim Horton.
+
+        We need to send the IOSurface to ViewSnapshot::create() for this to work.
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _takeViewSnapshot]):
+
 2015-09-18  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm

@@ -1113 +1113 @@
     CARenderServerRenderLayerWithTransform(MACH_PORT_NULL, self.layer.context.contextId, reinterpret_cast<uint64_t>(self.layer), surface->surface(), 0, 0, &transform);
 
-    return WebKit::ViewSnapshot::create(nullptr);
+    return WebKit::ViewSnapshot::create(WTF::move(surface));
 #else
     uint32_t slotID = [WebKit::ViewSnapshotStore::snapshottingContext() createImageSlot:snapshotSize hasAlpha:YES];