Changeset 190301 in webkit


Ignore:
Timestamp:
Sep 28, 2015, 6:55:31 PM (10 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: JSGlobalRuntimeAgent unintentionally overrides InspectorRuntimeAgent destruction handling
​https://bugs.webkit.org/show_bug.cgi?id=149537

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-28
Reviewed by Darin Adler.

  • inspector/agents/JSGlobalObjectRuntimeAgent.h:
  • inspector/agents/JSGlobalObjectRuntimeAgent.cpp:

(Inspector::JSGlobalObjectRuntimeAgent::willDestroyFrontendAndBackend): Deleted.
Do not override method, super class implementation is sufficient.

Fix file ordering.

  • inspector/agents/InspectorDebuggerAgent.h:

Remove unused member variable.

Location:
trunk/Source/JavaScriptCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r190289 r190301  
     12015-09-28  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Web Inspector: JSGlobalRuntimeAgent unintentionally overrides InspectorRuntimeAgent destruction handling
     4        https://bugs.webkit.org/show_bug.cgi?id=149537
     5
     6        Reviewed by Darin Adler.
     7
     8        * inspector/agents/JSGlobalObjectRuntimeAgent.h:
     9        * inspector/agents/JSGlobalObjectRuntimeAgent.cpp:
     10        (Inspector::JSGlobalObjectRuntimeAgent::willDestroyFrontendAndBackend): Deleted.
     11        Do not override method, super class implementation is sufficient.
     12
     13        * JavaScriptCore.xcodeproj/project.pbxproj:
     14        Fix file ordering.
     15
     16        * inspector/agents/InspectorDebuggerAgent.h:
     17        Remove unused member variable.
     18
    1192015-09-28  basile_clement@apple.com  <basile_clement@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
    220

  • trunk/Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.h

    r189834 r190301  
    174174    bool m_hasExceptionValue { false };
    175175    bool m_didPauseStopwatch { false };
    176     RefPtr<WTF::Stopwatch> m_stopwatch;
    177176};
    178177

  • trunk/Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.cpp

    r189438 r190301  
    4747}
    4848
    49 void JSGlobalObjectRuntimeAgent::willDestroyFrontendAndBackend(DisconnectReason)
    50 {
    51 }
    52 
    5349VM& JSGlobalObjectRuntimeAgent::globalVM()
    5450{

  • trunk/Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.h

    r189438 r190301  
    4040
    4141    virtual void didCreateFrontendAndBackend(FrontendRouter*, BackendDispatcher*) override;
    42     virtual void willDestroyFrontendAndBackend(DisconnectReason) override;
    4342
    4443    virtual JSC::VM& globalVM() override;
Note: See TracChangeset for help on using the changeset viewer.