Changeset 190372 in webkit

Timestamp:

Sep 30, 2015, 4:27:44 PM (10 years ago)

Author:

keith_miller@apple.com

Message:

Relanding r190289 with the following two fixes:

1. REGRESSION(r190289): It made Speedometer/Full.html performance test fail ​https://bugs.webkit.org/show_bug.cgi?id=149621

Reviewed by Saam Barati.

We need to restore callee saves for both the fast and slow paths before making a
tail call in the FTL.

• ftl/FTLJSCallBase.cpp: (JSC::FTL::JSCallBase::emit):

2. [ARM] REGRESSION(r190289): It made 374 tests crash on 32 bit ARM Linux ​https://bugs.webkit.org/show_bug.cgi?id=149619

Reviewed by Filip Pizlo.

Need to check for ARMv7_TRADITIONAL and ARMv7 in addition to ARM in "if"
statement to handle platforms with a link register.

• llint/LowLevelInterpreter.asm: (prepareForTailCall):

Patch by Michael Saboff <​msaboff@apple.com> on 2015-09-30

Location:

trunk/Source/JavaScriptCore

Files:

• CMakeLists.txt (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/CMakeLists.txt

@@ -1090 +1090 @@
     ${JAVASCRIPTCORE_DIR}/builtins/StringConstructor.js
     ${JAVASCRIPTCORE_DIR}/builtins/StringIterator.prototype.js
+    ${JAVASCRIPTCORE_DIR}/builtins/TypedArray.prototype.js
 )
 

trunk/Source/JavaScriptCore/ChangeLog

@@ -24 +24 @@
             * llint/LowLevelInterpreter.asm:
             (prepareForTailCall):
+
+2015-09-30  Keith Miller  <keith_miller@apple.com>
+
+        Unreviewed Windows buildfix.
+
+        * CMakeLists.txt:
 
 2015-09-30  Keith Miller  <keith_miller@apple.com>