Changeset 190516 in webkit


Ignore:
Timestamp:
Oct 2, 2015, 12:51:21 PM (10 years ago)
Author:
jer.noble@apple.com
Message:

[MSE] Browser crashes when appending invalid data to MSE source buffer
​https://bugs.webkit.org/show_bug.cgi?id=149689

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-source/media-source-stpp-crash.html

Bail out early (as specced) after disconnecting the SourceBuffer from its MediaSource.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):

LayoutTests:

  • media/content/stpp.mp4: Added.
  • media/media-source/media-source-stpp-crash-expected.txt: Added.
  • media/media-source/media-source-stpp-crash.html: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r190510 r190516  
     12015-10-02  Jer Noble  <jer.noble@apple.com>
     2
     3        [MSE] Browser crashes when appending invalid data to MSE source buffer
     4        https://bugs.webkit.org/show_bug.cgi?id=149689
     5
     6        Reviewed by Darin Adler.
     7
     8        * media/content/stpp.mp4: Added.
     9        * media/media-source/media-source-stpp-crash-expected.txt: Added.
     10        * media/media-source/media-source-stpp-crash.html: Added.
     11
    1122015-10-02  Alex Christensen  <achristensen@webkit.org>
    213

  • trunk/Source/WebCore/ChangeLog

    r190514 r190516  
     12015-10-02  Jer Noble  <jer.noble@apple.com>
     2
     3        [MSE] Browser crashes when appending invalid data to MSE source buffer
     4        https://bugs.webkit.org/show_bug.cgi?id=149689
     5
     6        Reviewed by Darin Adler.
     7
     8        Test: media/media-source/media-source-stpp-crash.html
     9
     10        Bail out early (as specced) after disconnecting the SourceBuffer from its MediaSource.
     11
     12        * Modules/mediasource/SourceBuffer.cpp:
     13        (WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
     14
    1152015-10-02  Simon Fraser  <simon.fraser@apple.com>
    216

  • trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp

    r187377 r190516  
    10231023    // 2. If the initialization segment has no audio, video, or text tracks, then run the append error algorithm
    10241024    // with the decode error parameter set to true and abort these steps.
    1025     if (!segment.audioTracks.size() && !segment.videoTracks.size() && !segment.textTracks.size())
     1025    if (segment.audioTracks.isEmpty() && segment.videoTracks.isEmpty() && segment.textTracks.isEmpty()) {
    10261026        appendError(true);
     1027        return;
     1028    }
    10271029
    10281030    // 3. If the first initialization segment flag is true, then run the following steps:
Note: See TracChangeset for help on using the changeset viewer.