Changeset 190550 in webkit

Timestamp:

Oct 4, 2015, 10:49:08 AM (10 years ago)

Author:

ap@apple.com

Message:

Support Trac 1.0.x XML timeline link format
​https://bugs.webkit.org/show_bug.cgi?id=149786

Reviewed by Lucas Forschler.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:

(Trac.prototype._convertCommitInfoElementToObject):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js

@@ -91 +91 @@
     {
         var link = doc.evaluate("./link", commitElement, null, XPathResult.STRING_TYPE).stringValue;
-        var revisionNumber = parseInt(/\d+$/.exec(link))
+
+        // There are multiple link formats for Trac that we support:
+        // https://trac.webkit.org/changeset/190497
+        // http://trac.foobar.com/repository/changeset/75388/project
+        var linkComponents = link.split("/");
+        var revisionNumber = parseInt(linkComponents.pop());
+        if (!revisionNumber)
+            var revisionNumber = parseInt(linkComponents.pop());
 
         function tracNSResolver(prefix)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-10-04  Alexey Proskuryakov  <ap@apple.com>
+
+        Support Trac 1.0.x XML timeline link format
+        https://bugs.webkit.org/show_bug.cgi?id=149786
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
+        (Trac.prototype._convertCommitInfoElementToObject):
+
 2015-10-04  Alexey Proskuryakov  <ap@apple.com>