Changeset 190898 in webkit

Timestamp:

Oct 12, 2015, 3:43:49 PM (10 years ago)

Author:

rniwa@webkit.org

Message:

Build fix after r190817. Now that pull-os-versions store fake timestamps, we need to bypass timestamp
checks for OS versions when bots try to report new results. Otherwise, we fail to process the reports
with a MismatchingCommitTime error.

• public/include/report-processor.php:

(ReportProcessor::resolve_build_id):

Location:

trunk/Websites/perf.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• public/include/report-processor.php (modified) (1 diff)

trunk/Websites/perf.webkit.org/ChangeLog

@@ +1 @@
+2015-10-11  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Build fix after r190817.  Now that pull-os-versions store fake timestamps, we need to bypass timestamp
+        checks for OS versions when bots try to report new results. Otherwise, we fail to process the reports
+        with a MismatchingCommitTime error.
+
+        * public/include/report-processor.php:
+        (ReportProcessor::resolve_build_id):
+
 2015-10-08  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Websites/perf.webkit.org/public/include/report-processor.php

@@ -153 +153 @@
             if (!$commit_row)
                 $this->exit_with_error('FailedToRecordCommit', $commit_data);
-            if (abs($commit_row['commit_time'] - $commit_data['time']) > 1.0)
+            if ($commit_data['time'] && abs($commit_row['commit_time'] - $commit_data['time']) > 1.0)
                 $this->exit_with_error('MismatchingCommitTime', array('existing' => $commit_row, 'new' => $commit_data));