Changeset 191999 in webkit

Timestamp:

Nov 3, 2015, 4:58:56 PM (10 years ago)

Author:

ggaren@apple.com

Message:

2015-11-03 Geoffrey Garen <​ggaren@apple.com>

Provide a way to turn off const in WebKit2.

Reviewed by Sam Weinig.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/js/JSDOMWindowBase.cpp (modified) (1 diff)
• WebCore/page/Settings.cpp (modified) (1 diff)
• WebCore/page/Settings.h (modified) (2 diffs)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/Shared/WebProcessCreationParameters.cpp (modified) (2 diffs)
• WebKit2/Shared/WebProcessCreationParameters.h (modified) (1 diff)
• WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm (modified) (2 diffs)
• WebKit2/WebProcess/WebProcess.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-11-03  Geoffrey Garen  <ggaren@apple.com>
+
+        Provide a way to turn off const in WebKit2.
+
+        Reviewed by Sam Weinig.
+
+        * bindings/js/JSDOMWindowBase.cpp:
+        (WebCore::JSDOMWindowBase::commonVM):
+        * page/Settings.h:
+        (WebCore::Settings::shouldUseHighResolutionTimers):
+        (WebCore::Settings::shouldRewriteConstAsVar):
+        (WebCore::Settings::setShouldRewriteConstAsVar):
+        (WebCore::Settings::backgroundShouldExtendBeyondPage):
+
 2015-11-03  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp

@@ -265 +265 @@
 
 #if PLATFORM(MAC)
-        if (applicationIsITunes() || applicationIsIBooks())
+        if (applicationIsITunes() || applicationIsIBooks() || Settings::shouldRewriteConstAsVar())
             vm->setShouldRewriteConstAsVar(true);
 #endif

trunk/Source/WebCore/page/Settings.cpp

@@ -85 +85 @@
 #endif
     
+bool Settings::gShouldRewriteConstAsVar = false;
 bool Settings::gShouldRespectPriorityInCSSAttributeSetters = false;
 bool Settings::gLowPowerVideoAudioBufferSizeEnabled = false;

trunk/Source/WebCore/page/Settings.h

@@ -200 +200 @@
 #endif
 
+    static bool shouldRewriteConstAsVar() { return gShouldRewriteConstAsVar; }
+    static void setShouldRewriteConstAsVar(bool shouldRewriteConstAsVar) { gShouldRewriteConstAsVar = shouldRewriteConstAsVar; }
+
     WEBCORE_EXPORT void setBackgroundShouldExtendBeyondPage(bool);
     bool backgroundShouldExtendBeyondPage() const { return m_backgroundShouldExtendBeyondPage; }
@@ -361 +364 @@
     static bool gShouldUseHighResolutionTimers;
 #endif
+    WEBCORE_EXPORT static bool gShouldRewriteConstAsVar;
     static bool gShouldRespectPriorityInCSSAttributeSetters;
 #if PLATFORM(IOS)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-11-03  Geoffrey Garen  <ggaren@apple.com>
+
+        Provide a way to turn off const in WebKit2.
+
+        Reviewed by Sam Weinig.
+
+        * Shared/WebProcessCreationParameters.cpp:
+        (WebKit::WebProcessCreationParameters::encode):
+        (WebKit::WebProcessCreationParameters::decode):
+        * Shared/WebProcessCreationParameters.h:
+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+        (WebKit::WebProcessPool::platformInitializeWebProcess):
+        * WebProcess/WebProcess.cpp:
+        (WebKit::WebProcess::initializeWebProcess):
+
 2015-11-03  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp

@@ -108 +108 @@
     encoder << fontWhitelist;
     encoder << iconDatabaseEnabled;
+    encoder << shouldRewriteConstAsVar;
     encoder << terminationTimeout;
     encoder << languages;
@@ -240 +241 @@
     if (!decoder.decode(parameters.iconDatabaseEnabled))
         return false;
+    if (!decoder.decode(parameters.shouldRewriteConstAsVar))
+        return false;
     if (!decoder.decode(parameters.terminationTimeout))
         return false;

trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h

@@ -118 +118 @@
 
     bool iconDatabaseEnabled;
+    bool shouldRewriteConstAsVar { false };
 
     double terminationTimeout;

trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm

@@ -45 +45 @@
 #import <WebCore/PlatformPasteboard.h>
 #import <WebCore/SharedBuffer.h>
+#import <WebCore/RuntimeApplicationChecks.h>
 #import <sys/param.h>
 
@@ -174 +175 @@
     parameters.shouldEnableFTLJIT = [[NSUserDefaults standardUserDefaults] boolForKey:WebKitJSCFTLJITEnabledDefaultsKey];
     parameters.shouldEnableMemoryPressureReliefLogging = [[NSUserDefaults standardUserDefaults] boolForKey:@"LogMemoryJetsamDetails"];
+
+#if PLATFORM(MAC)
+    parameters.shouldRewriteConstAsVar = applicationIsIBooks();
+#endif
 
 #if HAVE(HOSTED_CORE_ANIMATION)

trunk/Source/WebKit2/WebProcess/WebProcess.cpp

@@ -337 +337 @@
         registerURLSchemeAsCORSEnabled(scheme);
 
+    WebCore::Settings::setShouldRewriteConstAsVar(parameters.shouldRewriteConstAsVar);
+
 #if ENABLE(CACHE_PARTITIONING)
     for (auto& scheme : parameters.urlSchemesRegisteredAsCachePartitioned)