Changeset 192585 in webkit

Timestamp:

Nov 18, 2015, 1:46:33 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Timeline Recording across page navigations behaves poorly
​https://bugs.webkit.org/show_bug.cgi?id=151112

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-11-18
Reviewed by Timothy Hatcher.

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::frameStartedLoading): Deleted.
Don't reset the execution stopwatch on page navigation.
If a timeline is actively being recorded on the frontend
then all new timestamps suddenly downshifted towards zero
introduces bad data.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorPageAgent.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-11-18  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Timeline Recording across page navigations behaves poorly
+        https://bugs.webkit.org/show_bug.cgi?id=151112
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/InspectorPageAgent.cpp:
+        (WebCore::InspectorPageAgent::frameStartedLoading): Deleted.
+        Don't reset the execution stopwatch on page navigation.
+        If a timeline is actively being recorded on the frontend
+        then all new timestamps suddenly downshifted towards zero
+        introduces bad data.
+
 2015-11-18  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebCore/inspector/InspectorPageAgent.cpp

@@ -804 +804 @@
 void InspectorPageAgent::frameStartedLoading(Frame& frame)
 {
-    if (frame.isMainFrame()) {
-        auto stopwatch = m_environment.executionStopwatch();
-        stopwatch->reset();
-        stopwatch->start();
-    }
-
     m_frontendDispatcher->frameStartedLoading(frameId(&frame));
 }