Changeset 192715 in webkit


Ignore:
Timestamp:
Nov 20, 2015, 7:05:50 PM (10 years ago)
Author:
Simon Fraser
Message:

Animometer: graphs should not do interpolation
​https://bugs.webkit.org/show_bug.cgi?id=151526

Reviewed by Simon Fraser.

Having the graphs do interpolation is misleading, because you can't see the actual data.

Also remove "shape-rendering: crispEdges;" so the lines get antialiased.

  • Animometer/runner/resources/animometer.css:

(section#test-graph > data > svg): Deleted.

  • Animometer/runner/resources/graph.js:

(graph): Deleted.

Location:
trunk/PerformanceTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/PerformanceTests/Animometer/runner/resources/animometer.css

    r192550 r192715  
    420420section#test-graph > data > svg {
    421421    fill: none;
    422     shape-rendering: crispEdges; 
    423422}
    424423

  • trunk/PerformanceTests/Animometer/runner/resources/graph.js

    r192107 r192715  
    3131
    3232    var lineLeft = d3.svg.line()
    33             .interpolate("basis")
    3433            .x(function(d) { return x(d.timeOffset); })
    3534            .y(function(d) { return yLeft(d.values[0]); });
    3635
    3736    var lineRight = d3.svg.line()
    38             .interpolate("basis")
    3937            .x(function(d) { return x(d.timeOffset); })
    4038            .y(function(d) { return yRight(d.values[1]); });

  • trunk/PerformanceTests/ChangeLog

    r192669 r192715  
     12015-11-20  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Animometer: graphs should not do interpolation
     4        https://bugs.webkit.org/show_bug.cgi?id=151526
     5
     6        Reviewed by Simon Fraser.
     7       
     8        Having the graphs do interpolation is misleading, because you can't see the actual data.
     9       
     10        Also remove "shape-rendering: crispEdges;" so the lines get antialiased.
     11
     12        * Animometer/runner/resources/animometer.css:
     13        (section#test-graph > data > svg): Deleted.
     14        * Animometer/runner/resources/graph.js:
     15        (graph): Deleted.
     16
    1172015-11-19  Said Abou-Hallawa  <sabouhallawa@apple.com>
    218
Note: See TracChangeset for help on using the changeset viewer.