Changeset 194526 in webkit

Timestamp:

Jan 3, 2016, 7:48:49 PM (10 years ago)

Author:

ddkilzer@apple.com

Message:

-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:] is missing an m_handle->client() NULL check
<​https://webkit.org/b/152673>
<rdar://problem/23560530>

Reviewed by Daniel Bates.

• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
Add NULL check for m_handle->client() so we don't crash due to a
NULL dereference inside the dispatch_async() block.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-01-03  David Kilzer  <ddkilzer@apple.com>
+
+        -[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:] is missing an m_handle->client() NULL check
+        <https://webkit.org/b/152673>
+        <rdar://problem/23560530>
+
+        Reviewed by Daniel Bates.
+
+        * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
+        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
+        Add NULL check for m_handle->client() so we don't crash due to a
+        NULL dereference inside the dispatch_async() block.
+
 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm

@@ -197 +197 @@
 
     dispatch_async(dispatch_get_main_queue(), ^{
-        if (!m_handle) {
+        if (!m_handle || !m_handle->client()) {
             dispatch_semaphore_signal(m_semaphore);
             return;