Changeset 19606 in webkit

Timestamp:

Feb 13, 2007, 10:32:28 AM (19 years ago)

Author:

darin

Message:

JavaScriptCore:

Reviewed by Darin.

• fix for ​http://bugs.webkit.org/show_bug.cgi?id=12750 Vector operator== was not defined correctly. It returned void, did not accept const Vectors, and used an int instead of size_t.

• wtf/Vector.h: fixed comparison operators (WTF::operator==): (WTF::operator!=):

WebCore:

Reviewed by Darin.

• fix for ​http://bugs.webkit.org/show_bug.cgi?id=12750 Vector operator== was not defined correctly. It returned void, did not accept const Vectors, and used an int instead of size_t.

• rendering/RenderStyle.h: Added a != operator for StyleDashboardRegion. The only reason this compiled before was that the comparing two vectors with a != was simply comparing the pointers.

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/wtf/Vector.h (modified) (2 diffs)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderStyle.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2007-02-13  Dex Deacon  <occupant4@gmail.com>
+
+        Reviewed by Darin.
+
+        - fix for http://bugs.webkit.org/show_bug.cgi?id=12750
+          Vector operator== was not defined correctly. It returned void,
+          did not accept const Vectors, and used an int instead of size_t. 
+
+        * wtf/Vector.h: fixed comparison operators
+        (WTF::operator==):
+        (WTF::operator!=):
+
 2007-02-10  David Carson  <dacarson@gmail.com>
 

trunk/JavaScriptCore/wtf/Vector.h

@@ -664 +664 @@
 
     template<typename T, size_t inlineCapacity>
-    void operator==(Vector<T, inlineCapacity>& a, Vector<T, inlineCapacity>& b)
+    bool operator==(const Vector<T, inlineCapacity>& a, const Vector<T, inlineCapacity>& b)
     {
         if (a.size() != b.size())
             return false;
 
-        for (int i = 0; i < a.size(); ++i)
+        for (size_t i = 0; i < a.size(); ++i)
             if (a[i] != b[i])
                 return false;
@@ -677 +677 @@
 
     template<typename T, size_t inlineCapacity>
-    inline void operator!=(Vector<T, inlineCapacity>& a, Vector<T, inlineCapacity>& b)
+    inline bool operator!=(const Vector<T, inlineCapacity>& a, const Vector<T, inlineCapacity>& b)
     {
         return !(a == b);

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-02-13  Dex Deacon  <occupant4@gmail.com>
+
+        Reviewed by Darin.
+
+        - fix for http://bugs.webkit.org/show_bug.cgi?id=12750
+          Vector operator== was not defined correctly. It returned void,
+          did not accept const Vectors, and used an int instead of size_t. 
+
+        * rendering/RenderStyle.h: Added a != operator for StyleDashboardRegion.
+        The only reason this compiled before was that the comparing two vectors
+        with a != was simply comparing the pointers.
+
 2007-02-13  Darin Adler  <darin@apple.com>
 

trunk/WebCore/rendering/RenderStyle.h

@@ -382 +382 @@
         return type == o.type && offset == o.offset && label == o.label;
     }
+
+   bool operator!=(const StyleDashboardRegion& o) const
+   {
+       return !(*this == o);
+   }
 };