Changeset 198187 in webkit

Timestamp:

Mar 14, 2016, 6:52:02 PM (9 years ago)

Author:

Dewei Zhu

Message:

Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled.
​https://bugs.webkit.org/show_bug.cgi?id=154667

Reviewed by Ryosuke Niwa and Simon Fraser.

Add twisted-15.5.0 to webkitpy.thirdparty.autoinstalled.
Minor fix for twsited_http_server used by run-benchmark that we should only stop http server while recieving 'GET /shutdown'.

• Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:

(ServerControl.render_POST): Deleted.

• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_twisted_15_5_0):

• Scripts/webkitpy/thirdparty/init_unittest.py:

(ThirdpartyTest.test_imports):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py (modified) (2 diffs)
• Scripts/webkitpy/thirdparty/__init__.py (modified) (2 diffs)
• Scripts/webkitpy/thirdparty/__init___unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-03-14  Dewei Zhu  <dewei_zhu@apple.com>
+
+        Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled.
+        https://bugs.webkit.org/show_bug.cgi?id=154667
+
+        Reviewed by Ryosuke Niwa and Simon Fraser.
+
+        Add twisted-15.5.0 to webkitpy.thirdparty.autoinstalled.
+        Minor fix for twsited_http_server used by run-benchmark that we should only stop http server while recieving 'GET /shutdown'.
+
+        * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
+        (ServerControl.render_POST): Deleted.
+        * Scripts/webkitpy/thirdparty/__init__.py:
+        (AutoinstallImportHook.find_module):
+        (AutoinstallImportHook._install_twisted_15_5_0):
+        * Scripts/webkitpy/thirdparty/__init___unittest.py:
+        (ThirdpartyTest.test_imports):
+
 2016-03-14  Mark Lam  <mark.lam@apple.com>
 

trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py

@@ -10 +10 @@
 except ImportError:
     sys.path.append(os.path.abspath(os.path.join(os.path.dirname(os.path.abspath(__file__)), '../../../..')))
-    from webkitpy.thirdparty.autoinstalled.twisted import twisted
+    from webkitpy.thirdparty.autoinstalled.twisted_15_5_0 import twisted
 
 from twisted.web import static, server
@@ -30 +30 @@
         sys.stdout.write(request.content.getvalue())
         sys.stdout.flush()
-        reactor.stop()
         return 'OK'
 

trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py

@@ -92 +92 @@
         elif '.keyring' in fullname:
             self._install_keyring()
+        elif '.twisted_15_5_0' in fullname:
+            self._install_twisted_15_5_0()
         elif '.twisted' in fullname:
             self._install_twisted()
@@ -156 +158 @@
         installer.install(url="https://pypi.python.org/packages/source/T/Twisted/Twisted-12.1.0.tar.bz2#md5=f396f1d6f5321e869c2f89b2196a9eb5", url_subpath="Twisted-12.1.0/twisted")
 
+    def _install_twisted_15_5_0(self):
+        twisted_dir = self._fs.join(_AUTOINSTALLED_DIR, "twisted_15_5_0")
+        installer = AutoInstaller(prepend_to_search_path=True, target_dir=twisted_dir)
+        installer.install(url="https://pypi.python.org/packages/source/T/Twisted/Twisted-15.5.0.tar.bz2#md5=0831d7c90d0020062de0f7287530a285", url_subpath="Twisted-15.5.0/twisted")
+
     def _install(self, url, url_subpath=None, target_name=None):
         installer = AutoInstaller(target_dir=_AUTOINSTALLED_DIR)

trunk/Tools/Scripts/webkitpy/thirdparty/__init___unittest.py

@@ -65 +65 @@
         import webkitpy.thirdparty.autoinstalled.pylint
         import webkitpy.thirdparty.autoinstalled.pep8
+        import webkitpy.thirdparty.autoinstalled.twisted
+        import webkitpy.thirdparty.autoinstalled.twisted_15_5_0