Changeset 198967 in webkit

Timestamp:

Apr 1, 2016, 8:21:38 PM (9 years ago)

Author:

dbates@webkit.org

Message:

Attempt to fix the Apple Internal Yosemite and El Capitan builds following
<​http://trac.webkit.org/changeset/198933> (​https://bugs.webkit.org/show_bug.cgi?id=155455)
<rdar://problem/25502181>

Only check the code signature of the client app if the "user-directory-suffix" sandbox
initialization parameter will not be used. This parameter is only used/passed as an
initialization parameter if the client app is not sandboxed, which seems sufficient
criterion to determine whether it is safe to honor it.

• Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::initializeSandbox):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/mac/ChildProcessMac.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-04-01  Daniel Bates  <dabates@apple.com>
+
+        Attempt to fix the Apple Internal Yosemite and El Capitan builds following
+        <http://trac.webkit.org/changeset/198933> (https://bugs.webkit.org/show_bug.cgi?id=155455)
+        <rdar://problem/25502181>
+
+        Only check the code signature of the client app if the "user-directory-suffix" sandbox
+        initialization parameter will not be used. This parameter is only used/passed as an
+        initialization parameter if the client app is not sandboxed, which seems sufficient
+        criterion to determine whether it is safe to honor it.
+
+        * Shared/mac/ChildProcessMac.mm:
+        (WebKit::ChildProcess::initializeSandbox):
+
 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/Source/WebKit2/Shared/mac/ChildProcessMac.mm

@@ -209 +209 @@
     }
 
+    if (willUseUserDirectorySuffixInitializationParameter)
+        return;
     error = noErr;
     String clientCodeSigningIdentifier = codeSigningIdentifierForProcess(xpc_connection_get_pid(parameters.connectionIdentifier.xpcConnection.get()), error);
     bool isClientCodeSigned = !clientCodeSigningIdentifier.isNull();
-    if (isClientCodeSigned && willUseUserDirectorySuffixInitializationParameter) {
-        WTFLogAlways("%s: Only unsigned clients can specify parameter user-directory-suffix\n", getprogname());
-        exit(EX_NOPERM);
-    }
     if (isClientCodeSigned && clientCodeSigningIdentifier != parameters.clientIdentifier) {
         WTFLogAlways("%s: Code signing identifier of client differs from passed client identifier: %ld\n", getprogname(), static_cast<long>(error));