Changeset 199420 in webkit


Ignore:
Timestamp:
Apr 13, 2016, 12:35:08 AM (9 years ago)
Author:
Carlos Garcia Campos
Message:

Merge r198439 - Local file restrictions should not block sessionStorage access
​https://bugs.webkit.org/show_bug.cgi?id=155609
<rdar://problem/25229461>

Reviewed by Andy Estes.

Source/WebCore:

Use of 'sesssionStorage' is governed by SecurityOrigin with third party access
set to 'ShouldAllowFromThirdParty::AlwaysAllowFromThirdParty'. We should not
reject local files for this combination of arguments.

Test: storage/domstorage/sessionstorage/blocked-file-access.html

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canAccessStorage): For the case of sessionStorage,
allow local file access.

LayoutTests:

  • storage/domstorage/sessionstorage/blocked-file-access-expected.txt: Added.
  • storage/domstorage/sessionstorage/blocked-file-access.html: Added.
  • storage/domstorage/sessionstorage/resources/blocked-example.html: Added.
Location:
releases/WebKitGTK/webkit-2.12
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog

    r199418 r199420  
     12016-03-18  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Local file restrictions should not block sessionStorage access
     4        https://bugs.webkit.org/show_bug.cgi?id=155609
     5        <rdar://problem/25229461>
     6
     7        Reviewed by Andy Estes.
     8
     9        * storage/domstorage/sessionstorage/blocked-file-access-expected.txt: Added.
     10        * storage/domstorage/sessionstorage/blocked-file-access.html: Added.
     11        * storage/domstorage/sessionstorage/resources/blocked-example.html: Added.
     12
    1132016-03-18  Youenn Fablet  <youenn.fablet@crf.canon.fr>
    214

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog

    r199418 r199420  
     12016-03-18  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Local file restrictions should not block sessionStorage access
     4        https://bugs.webkit.org/show_bug.cgi?id=155609
     5        <rdar://problem/25229461>
     6
     7        Reviewed by Andy Estes.
     8
     9        Use of 'sesssionStorage' is governed by SecurityOrigin with third party access
     10        set to 'ShouldAllowFromThirdParty::AlwaysAllowFromThirdParty'. We should not
     11        reject local files for this combination of arguments.
     12
     13        Test: storage/domstorage/sessionstorage/blocked-file-access.html
     14
     15        * page/SecurityOrigin.cpp:
     16        (WebCore::SecurityOrigin::canAccessStorage): For the case of sessionStorage,
     17        allow local file access.
     18
    1192016-03-18  Youenn Fablet  <youenn.fablet@crf.canon.fr>
    220

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/page/SecurityOrigin.cpp

    r199347 r199420  
    376376        return false;
    377377
    378     if (isLocal() && !m_universalAccess)
     378    if (isLocal() && !m_universalAccess && shouldAllowFromThirdParty != AlwaysAllowFromThirdParty)
    379379        return false;
    380380
Note: See TracChangeset for help on using the changeset viewer.