Changeset 199542 in webkit

Timestamp:

Apr 14, 2016, 10:48:17 AM (9 years ago)

Author:

bshafiei@apple.com

Message:

Merged r199528. rdar://problem/25697779

Location:

tags/Safari-602.1.28/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/mac/CodeSigning.mm (modified) (1 diff)

tags/Safari-602.1.28/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-04-14  Babak Shafiei  <bshafiei@apple.com>
+
+        Merge r199528.
+
+    2016-04-13  Daniel Bates  <dabates@apple.com>
+
+            REGRESSION (r199401): Internal builds of Safari hang on launch
+            https://bugs.webkit.org/show_bug.cgi?id=156545
+            <rdar://problem/25697779>
+
+            As pointed out by Darin Adler, remove RELEASE_ASSERT() that I inadvertently left in
+            WebCore::secCodeForProcess() as part of r199504. For now, we handle
+            SecCodeCopyGuestWithAttributes() returning an error. In a subsequent commit we will
+            look to re-introduce the use of a RELEASE_ASSERT() to enforce the invariant that
+            SecCodeCopyGuestWithAttributes() returns a success status.
+
+            * Shared/mac/CodeSigning.mm:
+            (WebKit::secCodeForProcess):
+
 2016-04-13  Babak Shafiei  <bshafiei@apple.com>
 

tags/Safari-602.1.28/Source/WebKit2/Shared/mac/CodeSigning.mm

@@ -56 +56 @@
         return nullptr;
     }
-    RELEASE_ASSERT(!SecCodeCopyGuestWithAttributes(nullptr, attributes.get(), kSecCSDefaultFlags, &code));
     return adoptCF(code);
 }