Changeset 199678 in webkit

Timestamp:

Apr 18, 2016, 10:28:40 AM (9 years ago)

Author:

timothy@apple.com

Message:

Web Inspector: NavigationSidebarPanel does a lot of style recalc and layout on busy sites

​https://bugs.webkit.org/show_bug.cgi?id=156704
rdar://problem/25778744

Reviewed by Brian Burg.

• UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel):
(WebInspector.NavigationSidebarPanel.prototype._treeElementDisclosureDidChange):
Use _updateContentOverflowShadowVisibilitySoon in more places so the style recalc
and layout changes are coalesced into one action after all rapid fire calls.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/NavigationSidebarPanel.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-04-18  Timothy Hatcher  <timothy@apple.com>
+
+        Web Inspector: NavigationSidebarPanel does a lot of style recalc and layout on busy sites
+
+        https://bugs.webkit.org/show_bug.cgi?id=156704
+        rdar://problem/25778744
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/NavigationSidebarPanel.js:
+        (WebInspector.NavigationSidebarPanel):
+        (WebInspector.NavigationSidebarPanel.prototype._treeElementDisclosureDidChange):
+        Use _updateContentOverflowShadowVisibilitySoon in more places so the style recalc
+        and layout changes are coalesced into one action after all rapid fire calls.
+
 2016-04-18  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js

@@ -34 +34 @@
         this._visibleContentTreeOutlines = new Set;
 
-        this.contentView.element.addEventListener("scroll", this._updateContentOverflowShadowVisibility.bind(this));
+        this.contentView.element.addEventListener("scroll", this._updateContentOverflowShadowVisibilitySoon.bind(this));
 
         this._contentTreeOutline = this.createContentTreeOutline(true);
@@ -54 +54 @@
         }
 
-        this._boundUpdateContentOverflowShadowVisibility = this._updateContentOverflowShadowVisibility.bind(this);
+        this._boundUpdateContentOverflowShadowVisibility = this._updateContentOverflowShadowVisibilitySoon.bind(this);
         window.addEventListener("resize", this._boundUpdateContentOverflowShadowVisibility);
 
@@ -647 +647 @@
     _treeElementDisclosureDidChange(event)
     {
-        this._updateContentOverflowShadowVisibility();
+        this._updateContentOverflowShadowVisibilitySoon();
     }