Changeset 200410 in webkit

Timestamp:

May 4, 2016, 12:44:40 AM (9 years ago)

Author:

jiewen_tan@apple.com

Message:

CrashTracer: [USER] com.apple.WebKit.WebContent at …ple.WebCore: WebCore::EditCommandComposition::unapply + 105
​https://bugs.webkit.org/show_bug.cgi?id=157282
<rdar://problem/25391441>

Reviewed by Darin Adler.

A frame could be destroyed in the middle of executing undo/redo command.
Therefore, add an early return.

• editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/CompositeEditCommand.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-05-04  Jiewen Tan  <jiewen_tan@apple.com>
+
+        CrashTracer: [USER] com.apple.WebKit.WebContent at …ple.WebCore: WebCore::EditCommandComposition::unapply + 105
+        https://bugs.webkit.org/show_bug.cgi?id=157282
+        <rdar://problem/25391441>
+
+        Reviewed by Darin Adler.
+
+        A frame could be destroyed in the middle of executing undo/redo command.
+        Therefore, add an early return.
+
+        * editing/CompositeEditCommand.cpp:
+        (WebCore::EditCommandComposition::unapply):
+        (WebCore::EditCommandComposition::reapply):
+
 2016-05-04  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/editing/CompositeEditCommand.cpp

@@ -213 +213 @@
     ASSERT(m_document);
     RefPtr<Frame> frame = m_document->frame();
-    ASSERT(frame);
+    if (!frame)
+        return;
 
     m_replacedText.captureTextToBeDeletedByUnapply();
@@ -244 +245 @@
     ASSERT(m_document);
     RefPtr<Frame> frame = m_document->frame();
-    ASSERT(frame);
+    if (!frame)
+        return;
 
     m_replacedText.captureTextToBeDeletedByReapply();