Changeset 200452 in webkit

Timestamp:

May 5, 2016, 12:54:14 AM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Create console object lazily
​https://bugs.webkit.org/show_bug.cgi?id=157328

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-05
Reviewed by Geoffrey Garen.

• runtime/CommonIdentifiers.h:
• runtime/JSGlobalObject.cpp:

(JSC::createConsoleProperty):
(JSC::JSGlobalObject::init): Deleted.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/CommonIdentifiers.h (modified) (1 diff)
• runtime/JSGlobalObject.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-05-05  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Create console object lazily
+        https://bugs.webkit.org/show_bug.cgi?id=157328
+
+        Reviewed by Geoffrey Garen.
+
+        * runtime/CommonIdentifiers.h:
+        * runtime/JSGlobalObject.cpp:
+        (JSC::createConsoleProperty):
+        (JSC::JSGlobalObject::init): Deleted.
+
 2016-05-04  Michael Saboff  <msaboff@apple.com>
 

trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h

@@ -130 +130 @@
     macro(compile) \
     macro(configurable) \
-    macro(console) \
     macro(constructor) \
     macro(count) \

trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp

@@ -195 +195 @@
 }
 
+static JSValue createConsoleProperty(VM& vm, JSObject* object)
+{
+    JSGlobalObject* global = jsCast<JSGlobalObject*>(object);
+    return ConsoleObject::create(vm, global, ConsoleObject::createStructure(vm, global, global->objectPrototype()));
+}
+
 } // namespace JSC
 
@@ -223 +229 @@
   JSON                  createJSONProperty                           DontEnum|PropertyCallback
   Math                  createMathProperty                           DontEnum|PropertyCallback
+  console               createConsoleProperty                        DontEnum|PropertyCallback
   Int8Array             JSGlobalObject::m_typedArrayInt8             DontEnum|ClassStructure
   Int16Array            JSGlobalObject::m_typedArrayInt16            DontEnum|ClassStructure
@@ -635 +642 @@
     ReflectObject* reflectObject = ReflectObject::create(vm, this, ReflectObject::createStructure(vm, this, m_objectPrototype.get()));
     putDirectWithoutTransition(vm, vm.propertyNames->Reflect, reflectObject, DontEnum);
-
-    putDirectWithoutTransition(vm, vm.propertyNames->console, ConsoleObject::create(vm, this, ConsoleObject::createStructure(vm, this, m_objectPrototype.get())), DontEnum);
 
     m_moduleLoader.set(vm, this, ModuleLoaderObject::create(vm, this, ModuleLoaderObject::createStructure(vm, this, m_objectPrototype.get())));