Changeset 200590 in webkit


Ignore:
Timestamp:
May 9, 2016, 1:22:58 PM (9 years ago)
Author:
Simon Fraser
Message:

Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it
​https://bugs.webkit.org/show_bug.cgi?id=157480

Reviewed by Zalan Bujtas.

Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled()
and move it next to the other iOS text autosizing tests.
Tools:

Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree.

  • DumpRenderTree/TestRunner.cpp:

(setTextAutosizingEnabledCallback): Deleted.
(TestRunner::staticFunctions): Deleted.

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setTextAutosizingEnabled): Deleted.

LayoutTests:

  • fast/text-autosizing/ios/textarea-auto-sizing-disable-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable-expected.txt.
  • fast/text-autosizing/ios/textarea-auto-sizing-disable.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable.html.
  • platform/ios-simulator/TestExpectations:
Location:
trunk
Files:
5 edited
2 moved

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r200589 r200590  
     12016-05-09  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it
     4        https://bugs.webkit.org/show_bug.cgi?id=157480
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled()
     9        and move it next to the other iOS text autosizing tests.
     10
     11        * fast/text-autosizing/ios/textarea-auto-sizing-disable-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable-expected.txt.
     12        * fast/text-autosizing/ios/textarea-auto-sizing-disable.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable.html.
     13        * platform/ios-simulator/TestExpectations:
     14
    1152016-05-09  Simon Fraser  <simon.fraser@apple.com>
    216

  • trunk/LayoutTests/fast/text-autosizing/ios/textarea-auto-sizing-disable.html

    r200589 r200590  
    1515                return;
    1616
    17             // Enable autosizing
    18             testRunner.setTextAutosizingEnabled(true);
     17            window.internals.settings.setTextAutosizingEnabled(true);
     18            window.internals.settings.setTextAutosizingWindowSizeOverride(320, 480);
    1919           
    2020            var obj = document.getElementById('test');
    … …  
    3030            eventSender.keyDown('\n');
    3131           
    32             // Textarea heigth shouldn't change after we add new lines.
     32            // Textarea height shouldn't change after we add new lines.
    3333            document.getElementById("result").innerHTML= obj.offsetHeight == oldHeight ? 'SUCCESS' : 'FAIL';
    3434           

  • trunk/LayoutTests/platform/ios-simulator/TestExpectations

    r200534 r200590  
    120120platform/ios-simulator/ios/fast/forms/range-input-readonly-and-disabled.html [ Skip ]
    121121platform/ios-simulator/ios/fast/forms/range-input-touches.html [ Skip ]
    122 platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable.html [ Skip ]
    123122platform/ios-simulator/ios/fast/text/data-detectors/phone-disabled.html [ Skip ]
    124123platform/ios-simulator/ios/fast/text/data-detectors/phone.html [ Skip ]

  • trunk/Tools/ChangeLog

    r200547 r200590  
     12016-05-09  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it
     4        https://bugs.webkit.org/show_bug.cgi?id=157480
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled()
     9        and move it next to the other iOS text autosizing tests.
     10       
     11        Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree.
     12
     13        * DumpRenderTree/TestRunner.cpp:
     14        (setTextAutosizingEnabledCallback): Deleted.
     15        (TestRunner::staticFunctions): Deleted.
     16        * DumpRenderTree/mac/TestRunnerMac.mm:
     17        (TestRunner::setTextAutosizingEnabled): Deleted.
     18
    1192016-05-07  Darin Adler  <darin@apple.com>
    220

  • trunk/Tools/DumpRenderTree/TestRunner.cpp

    r200346 r200590  
    12411241    controller->setPagePaused(JSValueToBoolean(context, arguments[0]));
    12421242
    1243     return JSValueMakeUndefined(context);
    1244 }
    1245 #endif
    1246 
    1247 #if ENABLE(IOS_TEXT_AUTOSIZING)
    1248 static JSValueRef setTextAutosizingEnabledCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
    1249 {
    1250     if (argumentCount < 1)
    1251         return JSValueMakeUndefined(context);
    1252    
    1253     TestRunner* controller = static_cast<TestRunner*>(JSObjectGetPrivate(thisObject));
    1254     controller->setTextAutosizingEnabled(JSValueToBoolean(context, arguments[0]));
    1255    
    12561243    return JSValueMakeUndefined(context);
    12571244}
    … …  
    21472134        { "setPagePaused", setPagePausedCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    21482135#endif
    2149 #if ENABLE(IOS_TEXT_AUTOSIZING)
    2150         { "setTextAutosizingEnabled", setTextAutosizingEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    2151 #endif
    21522136        { "setUseDashboardCompatibilityMode", setUseDashboardCompatibilityModeCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    21532137        { "setUserStyleSheetEnabled", setUserStyleSheetEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },

  • trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm

    r200534 r200590  
    537537#endif
    538538
    539 #if ENABLE(IOS_TEXT_AUTOSIZING)
    540 void TestRunner::setTextAutosizingEnabled(bool enabled)
    541 {
    542     [[[mainFrame webView] preferences] _setTextAutosizingEnabled:enabled];
    543 }
    544 #endif
    545 
    546539void TestRunner::setUseDashboardCompatibilityMode(bool flag)
    547540{
Note: See TracChangeset for help on using the changeset viewer.