Changeset 200665 in webkit

Timestamp:

May 10, 2016, 6:55:47 PM (9 years ago)

Author:

Simon Fraser

Message:

Horizontally-scrollable items with a 3d transform are rendered incorrectly in RTL when container has -webkit-overflow-scroll: touch
​https://bugs.webkit.org/show_bug.cgi?id=157482
rdar://problem/26204794

Reviewed by Zalan Bujtas.
Source/WebCore:

The compositing code was confused about scroll offsets vs. scroll positions, because
of the badly named scrolledContentOffset(); we used that in one place, and scrollOffset()
lower down. Change both to use scrollOffset().

Test: compositing/rtl/rtl-with-transformed-descendants.html

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):

LayoutTests:

This can't be a ref test because on iOS ref test snapshots are doing by drawing, not by snapshotting layers.

• compositing/rtl/rtl-with-transformed-descendants-expected.txt: Added.
• compositing/rtl/rtl-with-transformed-descendants.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt (added)
• LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants.html (added)
• LayoutTests/platform/ios-simulator-wk1/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt (added)
• LayoutTests/platform/ios-simulator/compositing/rtl (added)
• LayoutTests/platform/ios-simulator/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerBacking.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-05-10  Simon Fraser  <simon.fraser@apple.com>
+
+        Horizontally-scrollable items with a 3d transform are rendered incorrectly in RTL when container has -webkit-overflow-scroll: touch
+        https://bugs.webkit.org/show_bug.cgi?id=157482
+        rdar://problem/26204794
+
+        Reviewed by Zalan Bujtas.
+        
+        This can't be a ref test because on iOS ref test snapshots are doing by drawing, not by snapshotting layers.
+
+        * compositing/rtl/rtl-with-transformed-descendants-expected.txt: Added.
+        * compositing/rtl/rtl-with-transformed-descendants.html: Added.
+
 2016-05-10  Hunseop Jeong  <hs85.jeong@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-05-10  Simon Fraser  <simon.fraser@apple.com>
+
+        Horizontally-scrollable items with a 3d transform are rendered incorrectly in RTL when container has -webkit-overflow-scroll: touch
+        https://bugs.webkit.org/show_bug.cgi?id=157482
+        rdar://problem/26204794
+
+        Reviewed by Zalan Bujtas.
+
+        The compositing code was confused about scroll offsets vs. scroll positions, because
+        of the badly named scrolledContentOffset(); we used that in one place, and scrollOffset()
+        lower down. Change both to use scrollOffset().
+
+        Test: compositing/rtl/rtl-with-transformed-descendants.html
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::updateGeometry):
+
 2016-05-10  Enrica Casucci  <enrica@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -816 +816 @@
             renderBox.height() - renderBox.borderTop() - renderBox.borderBottom());
 
-        IntSize scrollOffset = compAncestor->scrolledContentOffset();
+        ScrollOffset scrollOffset = compAncestor->scrollOffset();
         // FIXME: pixel snap the padding box.
-        graphicsLayerParentLocation = paddingBox.location() - scrollOffset;
+        graphicsLayerParentLocation = paddingBox.location() - toLayoutSize(scrollOffset);
     }
 #else