Changeset 200689 in webkit

Timestamp:

May 11, 2016, 9:24:31 AM (9 years ago)

Author:

commit-queue@webkit.org

Message:

preprocess-idls.pl not ignoring comments during processing
​https://bugs.webkit.org/show_bug.cgi?id=157559

Patch by Rawinder Singh <​rawinder.singh-webkit@cisra.canon.com.au> on 2016-05-11
Reviewed by Darin Adler.

Remove comments from IDL file before processing.

• bindings/scripts/preprocess-idls.pl:

(getInterfaceExtendedAttributesFromIDL):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/preprocess-idls.pl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-05-11  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
+
+        preprocess-idls.pl not ignoring comments during processing
+        https://bugs.webkit.org/show_bug.cgi?id=157559
+
+        Reviewed by Darin Adler.
+
+        Remove comments from IDL file before processing.
+
+        * bindings/scripts/preprocess-idls.pl:
+        (getInterfaceExtendedAttributesFromIDL):
+
 2016-05-11  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl

@@ -319 +319 @@
     my $extendedAttributes = {};
 
+    # Remove comments from fileContents before processing.
+    # FIX: Preference to use Regex::Common::comment, however it is not available on
+    # all build systems.
+    $fileContents =~ s/(?:(?:(?:\/\/)(?:[^\n]*)(?:\n))|(?:(?:\/\*)(?:(?:[^\*]+|\*(?!\/))*)(?:\*\/)))//g;
+
     if ($fileContents =~ /\[(.*)\]\s+(callback interface|interface|exception)\s+(\w+)/gs) {
         my @parts = split(m/,(?![^()]*\))/, $1);