Changeset 200720 in webkit

Timestamp:

May 11, 2016, 6:04:50 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Unexpected unread notification icon next to Log after clearing via clear()
​https://bugs.webkit.org/show_bug.cgi?id=157598

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-11
Reviewed by Timothy Hatcher.

We always show ConsoleCommand and ConsoleCommandResult messages no matter
what the filter is. So it doesn't make sense to mark the "log" filter
as having an unread notification for a ConsoleCommandResult when we can
see the result.

• UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype.didAppendConsoleMessageView):
(WebInspector.LogContentView.prototype._markScopeBarItemUnread):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/LogContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-05-11  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Unexpected unread notification icon next to Log after clearing via clear()
+        https://bugs.webkit.org/show_bug.cgi?id=157598
+
+        Reviewed by Timothy Hatcher.
+
+        We always show ConsoleCommand and ConsoleCommandResult messages no matter
+        what the filter is. So it doesn't make sense to mark the "log" filter
+        as having an unread notification for a ConsoleCommandResult when we can
+        see the result.
+
+        * UserInterface/Views/LogContentView.js:
+        (WebInspector.LogContentView.prototype.didAppendConsoleMessageView):
+        (WebInspector.LogContentView.prototype._markScopeBarItemUnread):
+
 2016-05-11  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js

@@ -163 +163 @@
         if (type && type !== WebInspector.ConsoleMessage.MessageType.EndGroup) {
             console.assert(messageView.message instanceof WebInspector.ConsoleMessage);
-            this._markScopeBarItemUnread(messageView.message.level);
+            if (!(messageView.message instanceof WebInspector.ConsoleCommandResultMessage))
+                this._markScopeBarItemUnread(messageView.message.level);
 
             console.assert(messageView.element instanceof Element);
@@ -315 +316 @@
     _markScopeBarItemUnread(level)
     {
-        var messageLevel = this._scopeFromMessageLevel(level);
-
+        let messageLevel = this._scopeFromMessageLevel(level);
         if (!messageLevel)
             return;
 
-        var item = this._scopeBar.item(messageLevel);
-
+        let item = this._scopeBar.item(messageLevel);
         if (item && !item.selected && !this._scopeBar.item(WebInspector.LogContentView.Scopes.All).selected)
             item.element.classList.add("unread");