Changeset 200828 in webkit

Timestamp:

May 13, 2016, 3:02:25 AM (9 years ago)

Author:

Carlos Garcia Campos

Message:

Merge r199875 - NetworkCacheIOChannelSoup: detach the newly-created IOChannel::readSync thread
​https://bugs.webkit.org/show_bug.cgi?id=156907

Reviewed by Carlos Garcia Campos.

• NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:

(WebKit::NetworkCache::IOChannel::readSyncInThread): Detach the new thread,
ensuring the resources are released after the thread exits. Next step is
to set up a thread pool and use that, avoiding thread re-creation.

Location:

releases/WebKitGTK/webkit-2.12/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp (modified) (2 diffs)

releases/WebKitGTK/webkit-2.12/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-04-22  Zan Dobersek  <zdobersek@igalia.com>
+
+        NetworkCacheIOChannelSoup: detach the newly-created IOChannel::readSync thread
+        https://bugs.webkit.org/show_bug.cgi?id=156907
+
+        Reviewed by Carlos Garcia Campos.
+
+        * NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
+        (WebKit::NetworkCache::IOChannel::readSyncInThread): Detach the new thread,
+        ensuring the resources are released after the thread exits. Next step is
+        to set up a thread pool and use that, avoiding thread re-creation.
+
 2016-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
 

releases/WebKitGTK/webkit-2.12/Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp

@@ -185 +185 @@
 
     RefPtr<IOChannel> channel(this);
-    createThread("IOChannel::readSync", [channel, size, queue, completionHandler] {
+    detachThread(createThread("IOChannel::readSync", [channel, size, queue, completionHandler] {
         size_t bufferSize = std::min(size, gDefaultReadBufferSize);
         uint8_t* bufferData = static_cast<uint8_t*>(fastMalloc(bufferSize));
@@ -219 +219 @@
             completionHandler(data, 0);
         }, queue);
-    });
+    }));
 }