Changeset 200857 in webkit

Timestamp:

May 13, 2016, 7:58:53 AM (9 years ago)

Author:

Chris Dumez

Message:

Have the WorkerGlobalScope API return more references
​https://bugs.webkit.org/show_bug.cgi?id=157663

Reviewed by Alexey Proskuryakov.

Have the WorkerGlobalScope API return more references instead of
pointers.

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::location):
(WebCore::WorkerGlobalScope::navigator):

• workers/WorkerGlobalScope.h:

(WebCore::WorkerGlobalScope::self):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• workers/WorkerGlobalScope.cpp (modified) (2 diffs)
• workers/WorkerGlobalScope.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-05-13  Chris Dumez  <cdumez@apple.com>
+
+        Have the WorkerGlobalScope API return more references
+        https://bugs.webkit.org/show_bug.cgi?id=157663
+
+        Reviewed by Alexey Proskuryakov.
+
+        Have the WorkerGlobalScope API return more references instead of
+        pointers.
+
+        * workers/WorkerGlobalScope.cpp:
+        (WebCore::WorkerGlobalScope::location):
+        (WebCore::WorkerGlobalScope::navigator):
+        * workers/WorkerGlobalScope.h:
+        (WebCore::WorkerGlobalScope::self):
+
 2016-05-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 

trunk/Source/WebCore/workers/WorkerGlobalScope.cpp

@@ -135 +135 @@
 #endif // ENABLE(INDEXED_DATABASE)
 
-WorkerLocation* WorkerGlobalScope::location() const
+WorkerLocation& WorkerGlobalScope::location() const
 {
     if (!m_location)
         m_location = WorkerLocation::create(m_url);
-    return m_location.get();
+    return *m_location;
 }
 
@@ -159 +159 @@
 }
 
-WorkerNavigator* WorkerGlobalScope::navigator() const
+WorkerNavigator& WorkerGlobalScope::navigator() const
 {
     if (!m_navigator)
         m_navigator = WorkerNavigator::create(m_userAgent);
-    return m_navigator.get();
+    return *m_navigator;
 }
 

trunk/Source/WebCore/workers/WorkerGlobalScope.h

@@ -91 +91 @@
 
     // WorkerGlobalScope
-    WorkerGlobalScope* self() { return this; }
-    WorkerLocation* location() const;
+    WorkerGlobalScope& self() { return *this; }
+    WorkerLocation& location() const;
     void close();
 
     // WorkerUtils
     virtual void importScripts(const Vector<String>& urls, ExceptionCode&);
-    WorkerNavigator* navigator() const;
+    WorkerNavigator& navigator() const;
 
     // Timers