Changeset 200893 in webkit

Timestamp:

May 13, 2016, 4:29:13 PM (9 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: Inform augmenting client when inspector controller is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=157688
<rdar://problem/25832724>

Reviewed by Timothy Hatcher.

• inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController):

• inspector/augmentable/AugmentableInspectorControllerClient.h:

There is a weak relationship between the InspectorController and the
AugmentingClient. Let the augmenting client know when the controller
is destroyed so it doesn't try to use us anymore.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/JSGlobalObjectInspectorController.cpp (modified) (1 diff)
• inspector/augmentable/AugmentableInspectorControllerClient.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-05-13  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Inform augmenting client when inspector controller is destroyed
+        https://bugs.webkit.org/show_bug.cgi?id=157688
+        <rdar://problem/25832724>
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/JSGlobalObjectInspectorController.cpp:
+        (Inspector::JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController):
+        * inspector/augmentable/AugmentableInspectorControllerClient.h:
+        There is a weak relationship between the InspectorController and the
+        AugmentingClient. Let the augmenting client know when the controller
+        is destroyed so it doesn't try to use us anymore.
+
 2016-05-13  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp

@@ -107 +107 @@
 JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController()
 {
+#if ENABLE(INSPECTOR_ALTERNATE_DISPATCHERS)
+    if (m_augmentingClient)
+        m_augmentingClient->inspectorControllerDestroyed();
+#endif
 }
 

trunk/Source/JavaScriptCore/inspector/augmentable/AugmentableInspectorControllerClient.h

@@ -34 +34 @@
 public:
     virtual ~AugmentableInspectorControllerClient() { }
+    virtual void inspectorControllerDestroyed() = 0;
     virtual void inspectorConnected() = 0;
     virtual void inspectorDisconnected() = 0;