Changeset 201190 in webkit

Timestamp:

May 19, 2016, 3:20:10 PM (9 years ago)

Author:

BJ Burg

Message:

Web Inspector: CRASH when closing a page while element selection mode is enabled via Develop menu
​https://bugs.webkit.org/show_bug.cgi?id=157925
<rdar://problem/26259618>

Reviewed by Joseph Pecoraro.

• WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::elementSelectionChanged):
Null-check m_page->inspector() since it will return nullptr if the page
is closed but not yet destructed. This is triggered by teardown code
in InspectorDOMAgent::willDestroyFrontendAndBackend.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebCoreSupport/WebInspectorClient.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-05-19  Brian Burg  <bburg@apple.com>
+
+        Web Inspector: CRASH when closing a page while element selection mode is enabled via Develop menu
+        https://bugs.webkit.org/show_bug.cgi?id=157925
+        <rdar://problem/26259618>
+
+        Reviewed by Joseph Pecoraro.
+
+        * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
+        (WebKit::WebInspectorClient::elementSelectionChanged):
+        Null-check m_page->inspector() since it will return nullptr if the page
+        is closed but not yet destructed. This is triggered by teardown code
+        in InspectorDOMAgent::willDestroyFrontendAndBackend.
+
 2016-05-19  Enrica Casucci  <enrica@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp

@@ -195 +195 @@
 void WebInspectorClient::elementSelectionChanged(bool active)
 {
-    m_page->inspector()->elementSelectionChanged(active);
+    if (m_page->inspector())
+        m_page->inspector()->elementSelectionChanged(active);
 }