Changeset 201192 in webkit

Timestamp:

May 19, 2016, 3:27:17 PM (9 years ago)

Author:

Nikita Vasilyev

Message:

REGRESSION (r189385): Web Inspector: CSS properties modified via JS don't update in the Styles sidebar
​https://bugs.webkit.org/show_bug.cgi?id=157918

Reviewed by Timothy Hatcher.

• UserInterface/Controllers/DOMTreeManager.js:

(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype._inlineStyleInvalidated):
(WebInspector.DOMTreeManager.prototype._loadNodeAttributes):
Set the initial value of _loadNodeAttributesTimeout to be 0,
as setTimeout always returns a positive integer.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/DOMTreeManager.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-05-19  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        REGRESSION (r189385): Web Inspector: CSS properties modified via JS don't update in the Styles sidebar
+        https://bugs.webkit.org/show_bug.cgi?id=157918
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Controllers/DOMTreeManager.js:
+        (WebInspector.DOMTreeManager):
+        (WebInspector.DOMTreeManager.prototype._inlineStyleInvalidated):
+        (WebInspector.DOMTreeManager.prototype._loadNodeAttributes):
+        Set the initial value of _loadNodeAttributesTimeout to be 0,
+        as setTimeout always returns a positive integer.
+
 2016-05-19  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js

@@ -43 +43 @@
         this._contentNodesToFlowsMap = new Map;
         this._restoreSelectedNodeIsAllowed = true;
+        this._loadNodeAttributesTimeout = 0;
 
         WebInspector.Frame.addEventListener(WebInspector.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this);
@@ -151 +152 @@
         for (var nodeId of nodeIds)
             this._attributeLoadNodeIds[nodeId] = true;
-        if ("_loadNodeAttributesTimeout" in this)
+        if (this._loadNodeAttributesTimeout)
             return;
         this._loadNodeAttributesTimeout = setTimeout(this._loadNodeAttributes.bind(this), 0);
@@ -172 +173 @@
         }
 
-        this._loadNodeAttributesTimeout = undefined;
+        this._loadNodeAttributesTimeout = 0;
 
         for (var nodeId in this._attributeLoadNodeIds) {