Changeset 201233 in webkit

Timestamp:

May 20, 2016, 4:46:06 PM (9 years ago)

Author:

jer.noble@apple.com

Message:

Inconsistent state in playback controls
​https://bugs.webkit.org/show_bug.cgi?id=157962
<rdar://problem/26397571>

Reviewed by Beth Dakin.

Do not use the playbackSessionManager() as the model, that's what the model is for.

• platform/mac/WebPlaybackSessionInterfaceMac.mm:

(WebCore::WebPlaybackSessionInterfaceMac::setClient):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/WebPlaybackSessionInterfaceMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-05-20  Jer Noble  <jer.noble@apple.com>
+
+        Inconsistent state in playback controls
+        https://bugs.webkit.org/show_bug.cgi?id=157962
+        <rdar://problem/26397571>
+
+        Reviewed by Beth Dakin.
+
+        Do not use the playbackSessionManager() as the model, that's what the model is for.
+
+        * platform/mac/WebPlaybackSessionInterfaceMac.mm:
+        (WebCore::WebPlaybackSessionInterfaceMac::setClient):
+
 2016-05-20  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/platform/mac/WebPlaybackSessionInterfaceMac.mm

@@ -59 +59 @@
     m_client = client;
 
-    if (m_client) {
-        float rate = [playBackControlsManager() rate];
-        m_client->rateChanged(!!rate, rate);
-    }
+    if (m_client && m_playbackSessionModel)
+        m_client->rateChanged(m_playbackSessionModel->isPlaying(), m_playbackSessionModel->playbackRate());
 }