Changeset 202031 in webkit

Timestamp:

Jun 13, 2016, 11:18:32 PM (9 years ago)

Author:

barraclough@apple.com

Message:

Remove hasStaticPropertyTable (part 4: JSHTMLDocument & JSStorage)
​https://bugs.webkit.org/show_bug.cgi?id=158431

Reviewed by Chris Dumez.

All uses of hasStaticPropertyTable flag generated by bindings are wrong.

JSHTMLDocument & JSStorage contain a number of static_asserts claiming that
various methods do not support static properties. These asserts were likely
correct at the time they were added, as JSObject::getOwnPropertySlot and
JSObject::deleteProperty did not support getting / deleting static value.
This is no longer the case, and these asserts are now incorrect.

• bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::getOwnPropertySlot):

• bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::deletePropertyByIndex):
(WebCore::JSStorage::putDelegate):

• remove incorrect static_asserts.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/JSHTMLDocumentCustom.cpp (modified) (1 diff)
• bindings/js/JSStorageCustom.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-13  Gavin & Ellie Barraclough  <barraclough@apple.com>
+
+        Remove hasStaticPropertyTable (part 4: JSHTMLDocument & JSStorage)
+        https://bugs.webkit.org/show_bug.cgi?id=158431
+
+        Reviewed by Chris Dumez.
+
+        All uses of hasStaticPropertyTable flag generated by bindings are wrong.
+
+        JSHTMLDocument & JSStorage contain a number of static_asserts claiming that
+        various methods do not support static properties. These asserts were likely
+        correct at the time they were added, as JSObject::getOwnPropertySlot and
+        JSObject::deleteProperty did not support getting / deleting static value.
+        This is no longer the case, and these asserts are now incorrect.
+
+        * bindings/js/JSHTMLDocumentCustom.cpp:
+        (WebCore::JSHTMLDocument::getOwnPropertySlot):
+        * bindings/js/JSStorageCustom.cpp:
+        (WebCore::JSStorage::deleteProperty):
+        (WebCore::JSStorage::deletePropertyByIndex):
+        (WebCore::JSStorage::putDelegate):
+            - remove incorrect static_asserts.
+
 2016-06-13  Gavin & Ellie Barraclough  <barraclough@apple.com>
 

trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp

@@ -90 +90 @@
     }
 
-    static_assert(!hasStaticPropertyTable, "This method does not handle static instance properties");
-
     return Base::getOwnPropertySlot(thisObject, exec, propertyName, slot);
 }

trunk/Source/WebCore/bindings/js/JSStorageCustom.cpp

@@ -60 +60 @@
     PropertySlot slot(thisObject, PropertySlot::InternalMethodType::GetOwnProperty);
 
-    static_assert(!hasStaticPropertyTable, "This function does not handle static instance properties");
-
     JSValue prototype = thisObject->getPrototypeDirect();
     if (prototype.isObject() && asObject(prototype)->getPropertySlot(exec, propertyName, slot))
@@ -77 +75 @@
 bool JSStorage::deletePropertyByIndex(JSCell* cell, ExecState* exec, unsigned propertyName)
 {
-    static_assert(!hasStaticPropertyTable, "This function does not handle static instance properties");
     return deleteProperty(cell, exec, Identifier::from(exec, propertyName));
 }
@@ -105 +102 @@
     // the native property slots manually.
     PropertySlot slot(this, PropertySlot::InternalMethodType::GetOwnProperty);
-    static_assert(!hasStaticPropertyTable, "This function does not handle static instance properties");
 
     JSValue prototype = this->getPrototypeDirect();