Changeset 203099 in webkit

Timestamp:

Jul 11, 2016, 4:53:42 PM (9 years ago)

Author:

weinig@apple.com

Message:

Speech Synthesis: getting list of voices no longer works
<rdar://problem/22954120>
​https://bugs.webkit.org/show_bug.cgi?id=159656

Reviewed by Tim Horton.

• platform/PlatformSpeechSynthesizer.h:
• platform/mac/PlatformSpeechSynthesizerMac.mm:

Default initialize m_voiceListIsInitialized to false so it is
initialized on both Mac and iOS. Remove the explicit initialization
from the Mac.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/PlatformSpeechSynthesizer.h (modified) (1 diff)
• platform/mac/PlatformSpeechSynthesizerMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-11  Sam Weinig  <sam@webkit.org>
+
+        Speech Synthesis: getting list of voices no longer works
+        <rdar://problem/22954120>
+        https://bugs.webkit.org/show_bug.cgi?id=159656
+
+        Reviewed by Tim Horton.
+
+        * platform/PlatformSpeechSynthesizer.h:
+        * platform/mac/PlatformSpeechSynthesizerMac.mm:
+        Default initialize m_voiceListIsInitialized to false so it is
+        initialized on both Mac and iOS. Remove the explicit initialization
+        from the Mac.
+
 2016-07-11  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/PlatformSpeechSynthesizer.h

@@ -87 +87 @@
     virtual void initializeVoiceList();
 
-    bool m_voiceListIsInitialized;
+    bool m_voiceListIsInitialized { false };
     PlatformSpeechSynthesizerClient* m_speechSynthesizerClient;
     

trunk/Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm

@@ -207 +207 @@
 
 PlatformSpeechSynthesizer::PlatformSpeechSynthesizer(PlatformSpeechSynthesizerClient* client)
-    : m_voiceListIsInitialized(false)
-    , m_speechSynthesizerClient(client)
+    : m_speechSynthesizerClient(client)
 {
 }