Changeset 203102 in webkit

Timestamp:

Jul 11, 2016, 8:30:05 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: ProfileView sometimes shows Top Functions data despite Top Functions being disabled
​https://bugs.webkit.org/show_bug.cgi?id=159660
<rdar://problem/27291647>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-11
Reviewed by Timothy Hatcher.

• UserInterface/Views/ScriptProfileTimelineView.js:

(WebInspector.ScriptProfileTimelineView.prototype._profileOrientationButtonClicked):
Pass the value of the setting, not the setting itself.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ScriptProfileTimelineView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-07-11  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: ProfileView sometimes shows Top Functions data despite Top Functions being disabled
+        https://bugs.webkit.org/show_bug.cgi?id=159660
+        <rdar://problem/27291647>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/ScriptProfileTimelineView.js:
+        (WebInspector.ScriptProfileTimelineView.prototype._profileOrientationButtonClicked):
+        Pass the value of the setting, not the setting itself.
+
 2016-07-11  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ScriptProfileTimelineView.js

@@ -143 +143 @@
 
         WebInspector.ScriptProfileTimelineView.profileOrientationSetting.value = newOrientation;
-        this._showProfileViewForOrientation(newOrientation, WebInspector.ScriptProfileTimelineView.profileTypeSetting);
+        this._showProfileViewForOrientation(newOrientation, WebInspector.ScriptProfileTimelineView.profileTypeSetting.value);
 
         this.dispatchEventToListeners(WebInspector.ContentView.Event.SelectionPathComponentsDidChange);