Changeset 203326 in webkit

Timestamp:

Jul 16, 2016, 10:21:07 AM (9 years ago)

Author:

Chris Dumez

Message:

Use fastHasAttribute() when possible
​https://bugs.webkit.org/show_bug.cgi?id=159838

Reviewed by Ryosuke Niwa.

Use fastHasAttribute() when possible, for performance.

• editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss):

• editing/markup.cpp:

(WebCore::createMarkupInternal):

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::draggable):

• html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):

• mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::getSelectedSemanticsChild):

• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::adjustMenuListButtonStyle):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/DeleteSelectionCommand.cpp (modified) (1 diff)
• editing/markup.cpp (modified) (1 diff)
• html/HTMLAnchorElement.cpp (modified) (1 diff)
• html/HTMLFrameElementBase.cpp (modified) (1 diff)
• mathml/MathMLSelectElement.cpp (modified) (2 diffs)
• rendering/RenderThemeIOS.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-16  Chris Dumez  <cdumez@apple.com>
+
+        Use fastHasAttribute() when possible
+        https://bugs.webkit.org/show_bug.cgi?id=159838
+
+        Reviewed by Ryosuke Niwa.
+
+        Use fastHasAttribute() when possible, for performance.
+
+        * editing/DeleteSelectionCommand.cpp:
+        (WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss):
+        * editing/markup.cpp:
+        (WebCore::createMarkupInternal):
+        * html/HTMLAnchorElement.cpp:
+        (WebCore::HTMLAnchorElement::draggable):
+        * html/HTMLFrameElementBase.cpp:
+        (WebCore::HTMLFrameElementBase::parseAttribute):
+        * mathml/MathMLSelectElement.cpp:
+        (WebCore::MathMLSelectElement::getSelectedSemanticsChild):
+        * rendering/RenderThemeIOS.mm:
+        (WebCore::RenderThemeIOS::adjustMenuListButtonStyle):
+
 2016-07-16  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp

@@ -435 +435 @@
     while (node && node != range->pastLastNode()) {
         RefPtr<Node> nextNode = NodeTraversal::next(*node);
-        if ((is<HTMLStyleElement>(*node) && !downcast<HTMLStyleElement>(*node).hasAttribute(scopedAttr)) || is<HTMLLinkElement>(*node)) {
+        if ((is<HTMLStyleElement>(*node) && !downcast<HTMLStyleElement>(*node).fastHasAttribute(scopedAttr)) || is<HTMLLinkElement>(*node)) {
             nextNode = NodeTraversal::nextSkippingChildren(*node);
             RefPtr<ContainerNode> rootEditableElement = node->rootEditableElement();

trunk/Source/WebCore/editing/markup.cpp

@@ -630 +630 @@
                 // appears to have no effect.
                 if ((!fullySelectedRootStyle || !fullySelectedRootStyle->style() || !fullySelectedRootStyle->style()->getPropertyCSSValue(CSSPropertyBackgroundImage))
-                    && fullySelectedRoot->hasAttribute(backgroundAttr))
+                    && fullySelectedRoot->fastHasAttribute(backgroundAttr))
                     fullySelectedRootStyle->style()->setProperty(CSSPropertyBackgroundImage, "url('" + fullySelectedRoot->getAttribute(backgroundAttr) + "')");
 

trunk/Source/WebCore/html/HTMLAnchorElement.cpp

@@ -282 +282 @@
     if (equalLettersIgnoringASCIICase(value, "false"))
         return false;
-    return hasAttribute(hrefAttr);
+    return fastHasAttribute(hrefAttr);
 }
 

trunk/Source/WebCore/html/HTMLFrameElementBase.cpp

@@ -100 +100 @@
         HTMLFrameOwnerElement::parseAttribute(name, value);
         // Falling back to using the 'id' attribute is not standard but some content relies on this behavior.
-        if (!hasAttribute(nameAttr))
+        if (!fastHasAttribute(nameAttr))
             m_frameName = value;
     } else if (name == nameAttr) {

trunk/Source/WebCore/mathml/MathMLSelectElement.cpp

@@ -175 +175 @@
         if (child->hasTagName(MathMLNames::annotationTag)) {
             // If the <annotation> element has an src attribute then it is a reference to arbitrary binary data and it is not clear whether we can display it. Hence we just ignore the annotation.
-            if (child->hasAttribute(MathMLNames::srcAttr))
+            if (child->fastHasAttribute(MathMLNames::srcAttr))
                 continue;
             // Otherwise, we assume it is a text annotation that can always be displayed and we stop here.
@@ -183 +183 @@
         if (child->hasTagName(MathMLNames::annotation_xmlTag)) {
             // If the <annotation-xml> element has an src attribute then it is a reference to arbitrary binary data and it is not clear whether we can display it. Hence we just ignore the annotation.
-            if (child->hasAttribute(MathMLNames::srcAttr))
+            if (child->fastHasAttribute(MathMLNames::srcAttr))
                 continue;
             // If the <annotation-xml> element has an encoding attribute describing presentation MathML, SVG or HTML we assume the content can be displayed and we stop here.

trunk/Source/WebCore/rendering/RenderThemeIOS.mm

@@ -626 +626 @@
     // or a date input. We don't force these if this is just an element with
     // "-webkit-appearance: menulist-button".
-    if (is<HTMLSelectElement>(*element) && !element->hasAttribute(HTMLNames::multipleAttr))
+    if (is<HTMLSelectElement>(*element) && !element->fastHasAttribute(HTMLNames::multipleAttr))
         adjustSelectListButtonStyle(style, *element);
     else if (is<HTMLInputElement>(*element))